x86 cache-as-ram: Remove BROKEN_CAR_MIGRATE option
This was added to handle cases of Intel FSP platforms that had EARLY_CBMEM_INIT but could not migrate CAR variables to CBMEM. These boards were recently fixed. To support combination of EARLY_CBMEM_INIT without CAR migration was added maintenance effort with little benefits. You had no CBMEM console for romstage and the few timestamps you could store were circulated via PCI scratchpads or CMOS nvram. Change-Id: I5cffb7f2b14c45b67ee70cf48be4d7a4c9e5f761 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/8636 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@google.com>
This commit is contained in:
@@ -34,7 +34,6 @@ config CPU_AMD_AGESA
|
||||
select TSC_SYNC_LFENCE
|
||||
select UDELAY_LAPIC
|
||||
select LAPIC_MONOTONIC_TIMER
|
||||
select BROKEN_CAR_MIGRATE
|
||||
select SPI_FLASH if HAVE_ACPI_RESUME
|
||||
|
||||
if CPU_AMD_AGESA
|
||||
|
@@ -29,7 +29,6 @@ config CPU_AMD_PI
|
||||
select TSC_SYNC_LFENCE
|
||||
select UDELAY_LAPIC
|
||||
select LAPIC_MONOTONIC_TIMER
|
||||
select BROKEN_CAR_MIGRATE
|
||||
select SPI_FLASH if HAVE_ACPI_RESUME
|
||||
|
||||
if CPU_AMD_PI
|
||||
|
@@ -6,7 +6,6 @@ config CPU_INTEL_EP80579
|
||||
select ARCH_RAMSTAGE_X86_32
|
||||
select SSE
|
||||
select SUPPORT_CPU_UCODE_IN_CBFS
|
||||
select BROKEN_CAR_MIGRATE
|
||||
|
||||
if CPU_INTEL_EP80579
|
||||
|
||||
|
@@ -149,9 +149,8 @@ static void do_car_migrate_hooks(void)
|
||||
|
||||
void car_migrate_variables(void)
|
||||
{
|
||||
if (!IS_ENABLED(CONFIG_BROKEN_CAR_MIGRATE) && !IS_ENABLED(PLATFORM_USES_FSP))
|
||||
if (!IS_ENABLED(PLATFORM_USES_FSP))
|
||||
do_car_migrate_variables();
|
||||
|
||||
if (!IS_ENABLED(CONFIG_BROKEN_CAR_MIGRATE))
|
||||
do_car_migrate_hooks();
|
||||
do_car_migrate_hooks();
|
||||
}
|
||||
|
Reference in New Issue
Block a user