AMD binaryPI: Disable PCI_CFG_EXT_IO
We don't need to do explicit pci_io_read/write operations, as we can use MMCONF everywhere. AGESA code still enables extended cf8/cfc should it be needed by payload or OS. Change-Id: Ib08028bda1b5226bb3b6b67e91f514480a9fc5ee Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/17536 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
		| @@ -15,7 +15,6 @@ | ||||
|  | ||||
| config CPU_AMD_PI_00630F01 | ||||
| 	bool | ||||
| 	select PCI_IO_CFG_EXT | ||||
| 	select MMCONF_SUPPORT_DEFAULT | ||||
| 	select X86_AMD_FIXED_MTRRS | ||||
|  | ||||
|   | ||||
| @@ -72,13 +72,6 @@ void amd_initmmio(void) | ||||
| 	MsrReg = CONFIG_MMCONF_BASE_ADDRESS | (LibAmdBitScanReverse (CONFIG_MMCONF_BUS_NUMBER) << 2) | 1; | ||||
| 	LibAmdMsrWrite (0xC0010058, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* | ||||
| 	  Set the NB_CFG MSR register. Enable CF8 extended configuration cycles. | ||||
| 	*/ | ||||
| 	LibAmdMsrRead (0xC001001F, &MsrReg, &StdHeader); | ||||
| 	MsrReg = MsrReg | 0x0000400000000000; | ||||
| 	LibAmdMsrWrite (0xC001001F, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* Set ROM cache onto WP to decrease post time */ | ||||
| 	MsrReg = (0x0100000000ull - CACHE_ROM_SIZE) | 5ull; | ||||
| 	LibAmdMsrWrite (0x20C, &MsrReg, &StdHeader); | ||||
|   | ||||
| @@ -15,7 +15,6 @@ | ||||
|  | ||||
| config CPU_AMD_PI_00660F01 | ||||
| 	bool | ||||
| 	select PCI_IO_CFG_EXT | ||||
| 	select MMCONF_SUPPORT_DEFAULT | ||||
| 	select X86_AMD_FIXED_MTRRS | ||||
|  | ||||
|   | ||||
| @@ -74,13 +74,6 @@ void amd_initmmio(void) | ||||
| 	MsrReg = CONFIG_MMCONF_BASE_ADDRESS | (LibAmdBitScanReverse (CONFIG_MMCONF_BUS_NUMBER) << 2) | 1; | ||||
| 	LibAmdMsrWrite (0xC0010058, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* | ||||
| 	  Set the NB_CFG MSR register. Enable CF8 extended configuration cycles. | ||||
| 	*/ | ||||
| 	LibAmdMsrRead (0xC001001F, &MsrReg, &StdHeader); | ||||
| 	MsrReg = MsrReg | 0x0000400000000000; | ||||
| 	LibAmdMsrWrite (0xC001001F, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* For serial port */ | ||||
| 	PciData = 0xFF03FFD5; | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x14, 0x3, 0x44); | ||||
|   | ||||
| @@ -15,7 +15,6 @@ | ||||
|  | ||||
| config CPU_AMD_PI_00670F00 | ||||
| 	bool | ||||
| 	select PCI_IO_CFG_EXT | ||||
| 	select MMCONF_SUPPORT_DEFAULT | ||||
| 	select X86_AMD_FIXED_MTRRS | ||||
|  | ||||
|   | ||||
| @@ -77,13 +77,6 @@ void amd_initmmio(void) | ||||
| 		(LibAmdBitScanReverse (CONFIG_MMCONF_BUS_NUMBER) << 2) | 1; | ||||
| 	LibAmdMsrWrite(0xC0010058, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* | ||||
| 	  Set the NB_CFG MSR register. Enable CF8 extended config cycles. | ||||
| 	*/ | ||||
| 	LibAmdMsrRead(0xC001001F, &MsrReg, &StdHeader); | ||||
| 	MsrReg = MsrReg | 0x0000400000000000; | ||||
| 	LibAmdMsrWrite(0xC001001F, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* For serial port */ | ||||
| 	PciData = 0xFF03FFD5; | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x14, 0x3, 0x44); | ||||
|   | ||||
| @@ -15,7 +15,6 @@ | ||||
|  | ||||
| config CPU_AMD_PI_00730F01 | ||||
| 	bool | ||||
| 	select PCI_IO_CFG_EXT | ||||
| 	select MMCONF_SUPPORT_DEFAULT | ||||
| 	select X86_AMD_FIXED_MTRRS | ||||
|  | ||||
|   | ||||
| @@ -74,13 +74,6 @@ void amd_initmmio(void) | ||||
| 	MsrReg = CONFIG_MMCONF_BASE_ADDRESS | (LibAmdBitScanReverse (CONFIG_MMCONF_BUS_NUMBER) << 2) | 1; | ||||
| 	LibAmdMsrWrite (0xC0010058, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* | ||||
| 	  Set the NB_CFG MSR register. Enable CF8 extended configuration cycles. | ||||
| 	*/ | ||||
| 	LibAmdMsrRead (0xC001001F, &MsrReg, &StdHeader); | ||||
| 	MsrReg = MsrReg | 0x0000400000000000; | ||||
| 	LibAmdMsrWrite (0xC001001F, &MsrReg, &StdHeader); | ||||
|  | ||||
| 	/* For serial port */ | ||||
| 	PciData = 0xFF03FFD5; | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x14, 0x3, 0x44); | ||||
|   | ||||
		Reference in New Issue
	
	Block a user