sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/mediatek/common: Print error if GPIO raw_id is not in the range

Browse Source 
TEST=build pass
BUG=317009620

Change-Id: I5dffdb9f3e4e7e0d49209e6012893cd246948ee8
Signed-off-by: Jarried Lin <jarried.lin@mediatek.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83987
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yidi Lin <yidilin@google.com>
This commit is contained in:
Jarried Lin 2024-08-20 17:33:49 +08:00 committed by Felix Held
parent 2f3d534eea
commit d2328698ac
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/soc/mediatek/common/gpio.c
View File

@ -189,8 +189,10 @@ int gpio_set_driving(gpio_t gpio, uint8_t drv)
const struct gpio_drv_info *adv_info = get_gpio_driving_adv_info(gpio.id);
void *reg, *reg_adv, *reg_addr;
if (!info)
if (!info) {
printk(BIOS_ERR, "%s: raw_id %u is out of range\n", __func__, gpio.id);
return -1;
}
if (!is_valid_drv(drv))
return -1;
@ -221,8 +223,10 @@ int gpio_get_driving(gpio_t gpio)
const struct gpio_drv_info *info = get_gpio_driving_info(gpio.id);
void *reg;
if (!info)
if (!info) {
printk(BIOS_ERR, "%s: raw_id %u is out of range\n", __func__, gpio.id);
return -1;
}
if (info->width == 0)
return -1;
@ -237,8 +241,10 @@ int gpio_set_driving_adv(gpio_t gpio, enum gpio_drv_adv drv)
const struct gpio_drv_info *adv_info = get_gpio_driving_adv_info(gpio.id);
void *reg_adv;
if (!adv_info)
if (!adv_info) {
printk(BIOS_ERR, "%s: raw_id %u is out of range\n", __func__, gpio.id);
return -1;
}
if (!is_valid_drv_adv(drv))
return -1;
@ -266,8 +272,10 @@ int gpio_get_driving_adv(gpio_t gpio)
void *reg_adv;
uint32_t drv;
if (!adv_info)
if (!adv_info) {
printk(BIOS_ERR, "%s: raw_id %u is out of range\n", __func__, gpio.id);
return -1;
}
if (adv_info->width == 0)
return -1;