sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim/var/skyrim: Add VL822 USB hub

Browse Source 
In Skyrim, USB-A port and WWAN modules are connected to the SoC USB
ports through an external hub. Update the USB configuration in the
devicetree accordingly. Enable the ACPI driver for external USB hub.

BUG=b:227761300
TEST=Build and boot to OS in Skyrim. Ensure that the hub and USB-A ports
are enumerated correctly in the output of lusub command.

Change-Id: Ibf6a3da8add7361fc50adcf7c62e46df234685dc
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63586
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Karthikeyan Ramasubramanian
2022-05-02 13:30:57 -06:00
committed by Tim Wawrzynczak
parent 0bb5b1c58a
commit d52adc4a87
3 changed files with 43 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/skyrim/Kconfig
View File

@@ -18,6 +18,7 @@ config BOARD_SPECIFIC_OPTIONS
select DRIVERS_GENERIC_GPIO_KEYS
select DRIVERS_I2C_GENERIC
select DRIVERS_I2C_HID
select DRIVERS_USB_HUB
select DRIVERS_WIFI_GENERIC
select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_ESPI

12
src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
View File

@@ -104,24 +104,12 @@ chip soc/amd/sabrina
register "group" = "ACPI_PLD_GROUP(2, 1)"
device ref usb3_port2 on end
end
chip drivers/usb/acpi
register "desc" = ""Left Type-A Port""
register "type" = "UPC_TYPE_USB3_A"
register "group" = "ACPI_PLD_GROUP(2, 2)"
device ref usb3_port3 on end
end
chip drivers/usb/acpi
register "desc" = ""Left Type-C Port""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(2, 1)"
device ref usb2_port2 on end
end
chip drivers/usb/acpi
register "desc" = ""Left Type-A Port""
register "type" = "UPC_TYPE_USB3_A"
register "group" = "ACPI_PLD_GROUP(2, 2)"
device ref usb2_port3 on end
end
chip drivers/usb/acpi
register "desc" = ""World-Facing Camera""
register "type" = "UPC_TYPE_INTERNAL"

42
src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
View File

@@ -28,6 +28,48 @@ end
chip soc/amd/sabrina
device domain 0 on
device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A
device ref xhci_1 on # XHCI1 controller
chip drivers/usb/acpi
device ref xhci_1_root_hub on # XHCI1 root hub
chip drivers/usb/acpi
device ref usb3_port3 on # USB 3.1 port3
chip drivers/usb/hub
register "desc" = ""USB Hub""
register "name" = ""VL822""
register "port_count" = "4"
device usb 0.0 on # VL822 USB3 hub
chip drivers/usb/acpi
register "desc" = ""Left Type-A Port""
register "type" = "UPC_TYPE_USB3_A"
register "group" = "ACPI_PLD_GROUP(2, 2)"
device usb 3.0 on end
end
end # VL822 USB3 hub
end
end # USB 3.1 port3
end
chip drivers/usb/acpi
device ref usb2_port3 on # USB 2 port3
chip drivers/usb/hub
register "desc" = ""USB Hub""
register "name" = ""VL822""
register "port_count" = "4"
device usb 0.0 on # VL822 USB2 hub
chip drivers/usb/acpi
register "desc" = ""Left Type-A Port""
register "type" = "UPC_TYPE_USB3_A"
register "group" = "ACPI_PLD_GROUP(2, 2)"
device usb 2.0 on end
end
end # VL822 USB2 hub
end
end # USB 2 port3
end
end # XHCI1 root hub
end
end # XHCI1 controller
end # Internal GPP Bridge 0 to Bus A
end # domain
# I2C Config