skl mainboards/dt: Drop SataSalpSupport setting if disabled

The attributes are initialized with 0 and thus setting them to 0 makes
them superfluous. Remove them.

Change-Id: Icb41f0a9baded01267410bd4c9458ab4bfb82b70
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83175
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marvin Evers <marvin.n.evers@gmail.com>
This commit is contained in:
Felix Singer
2024-06-23 04:18:47 +02:00
parent 842ee24340
commit d91e20f19b
16 changed files with 0 additions and 16 deletions

View File

@ -58,7 +58,6 @@ chip soc/intel/skylake
device ref thermal on end device ref thermal on end
device ref heci1 on end device ref heci1 on end
device ref sata on device ref sata on
register "SataSalpSupport" = "0"
# Ports # Ports
register "SataPortsEnable[0]" = "1" register "SataPortsEnable[0]" = "1"
register "SataPortsEnable[2]" = "1" register "SataPortsEnable[2]" = "1"

View File

@ -36,7 +36,6 @@ chip soc/intel/skylake
register "gen3_dec" = "0x00fc0901" register "gen3_dec" = "0x00fc0901"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -65,7 +65,6 @@ chip soc/intel/skylake
register "s0ix_enable" = true register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "1" register "SataPortsEnable[0]" = "1"
register "SataPortsEnable[1]" = "1" register "SataPortsEnable[1]" = "1"
register "SataPortsDevSlp[1]" = "1" register "SataPortsDevSlp[1]" = "1"

View File

@ -35,7 +35,6 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -43,7 +43,6 @@ chip soc/intel/skylake
register "CmdTriStateDis" = "1" register "CmdTriStateDis" = "1"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -31,7 +31,6 @@ chip soc/intel/skylake
register "s0ix_enable" = true register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -40,7 +40,6 @@ chip soc/intel/skylake
register "s0ix_enable" = true register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"
register "ScsEmmcHs400Enabled" = "1" register "ScsEmmcHs400Enabled" = "1"

View File

@ -40,7 +40,6 @@ chip soc/intel/skylake
register "s0ix_enable" = true register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -36,7 +36,6 @@ chip soc/intel/skylake
register "CmdTriStateDis" = "1" register "CmdTriStateDis" = "1"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -43,7 +43,6 @@ chip soc/intel/skylake
register "CmdTriStateDis" = "1" register "CmdTriStateDis" = "1"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -40,7 +40,6 @@ chip soc/intel/skylake
register "s0ix_enable" = true register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "0" register "SataPortsEnable[0]" = "0"
register "DspEnable" = "1" register "DspEnable" = "1"
register "IoBufferOwnership" = "3" register "IoBufferOwnership" = "3"

View File

@ -33,7 +33,6 @@ chip soc/intel/skylake
register "dptf_enable" = "0" register "dptf_enable" = "0"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable" = "{ register "SataPortsEnable" = "{
[0] = 1, [0] = 1,
[1] = 1, [1] = 1,

View File

@ -28,7 +28,6 @@ chip soc/intel/skylake
register "tcc_offset" = "5" # TCC of 95C register "tcc_offset" = "5" # TCC of 95C
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "DspEnable" = "0" register "DspEnable" = "0"
register "IoBufferOwnership" = "0" register "IoBufferOwnership" = "0"
register "SkipExtGfxScan" = "1" register "SkipExtGfxScan" = "1"

View File

@ -41,7 +41,6 @@ chip soc/intel/skylake
register "dptf_enable" = "0" register "dptf_enable" = "0"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable[0]" = "1" register "SataPortsEnable[0]" = "1"
register "SataPortsEnable[1]" = "0" register "SataPortsEnable[1]" = "0"
register "SataPortsEnable[2]" = "1" register "SataPortsEnable[2]" = "1"

View File

@ -22,7 +22,6 @@ chip soc/intel/skylake
register "dptf_enable" = "0" register "dptf_enable" = "0"
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0"
register "SataPortsEnable" = "{ register "SataPortsEnable" = "{
[0] = 0, [0] = 0,
[1] = 0, [1] = 0,

View File

@ -128,7 +128,6 @@ chip soc/intel/skylake
end end
device ref thermal on end device ref thermal on end
device ref sata on device ref sata on
register "SataSalpSupport" = "0"
register "SataSpeedLimit" = "2" register "SataSpeedLimit" = "2"
register "SataPortsEnable" = "{ register "SataPortsEnable" = "{
[0] = 1, [0] = 1,