mb/google/brya: Enable FSP UPD LpDdrDqDqsReTraining

FSP default value for LpDdrDqDqsReTraining is 1. For boards
that didn't set LpDdrDqDqsReTraining to any value, 0 was being
assigned and it caused black screen issue.

BUG=b:302465393
TEST=Boot to OS with debug FSP, check LpDdrDqDqsReTraining = 1

Signed-off-by: Bora Guvendik <bora.guvendik@intel.com>
Change-Id: I301a6e43f2944ffbc63431393378ab8b23450032
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79527
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
This commit is contained in:
Bora Guvendik
2023-12-13 11:14:01 -08:00
committed by Nick Vaccaro
parent 0b7388f050
commit d9c347fb8b
19 changed files with 44 additions and 0 deletions

View File

@@ -61,6 +61,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};

View File

@@ -16,6 +16,8 @@ static const struct mb_cfg ddr4_mem_config = {
.targets = {50, 20, 25, 25, 25},
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_MOBILE,

View File

@@ -14,6 +14,8 @@ static const struct mb_cfg ddr4_mem_config = {
.targets = {50, 20, 25, 25, 25},
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_MOBILE,

View File

@@ -16,6 +16,8 @@ static const struct mb_cfg ddr4_mem_config = {
.targets = {50, 20, 25, 25, 25},
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_MOBILE,

View File

@@ -63,6 +63,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};

View File

@@ -16,6 +16,8 @@ static const struct mb_cfg ddr5_mem_config = {
.targets = {50, 20, 25, 25, 25},
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_MOBILE,

View File

@@ -63,6 +63,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ddr7 = { .dqs0 = 1, .dqs1 = 0 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};

View File

@@ -67,6 +67,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ccc_config = 0xff,
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
};

View File

@@ -16,6 +16,8 @@ static const struct mb_cfg ddr4_mem_config = {
.targets = {50, 20, 25, 25, 25},
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_MOBILE,

View File

@@ -63,6 +63,8 @@ static const struct mb_cfg kano_memcfg = {
.ddr7 = { .dqs0 = 1, .dqs1 = 0 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};
@@ -125,6 +127,8 @@ static const struct mb_cfg hynix_memcfg = {
.ddr7 = { .dqs0 = 1, .dqs1 = 0 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
.cs_pi_start_high_in_ect = 1,

View File

@@ -17,6 +17,8 @@ static const struct mb_cfg ddr4_mem_config = {
.targets = {50, 20, 25, 25, 25},
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_MOBILE,

View File

@@ -65,6 +65,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ccc_config = 0xff,
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_ULT_ULX,

View File

@@ -16,6 +16,8 @@ static const struct mb_cfg ddr4_mem_config = {
.targets = {50, 20, 25, 25, 25},
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_MOBILE,

View File

@@ -67,6 +67,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ect = 1, /* Early Command Training */
.LpDdrDqDqsReTraining = 1,
.UserBd = BOARD_TYPE_ULT_ULX,
};

View File

@@ -63,6 +63,8 @@ static const struct mb_cfg osiris_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};
@@ -125,6 +127,8 @@ static const struct mb_cfg hynix_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
.cs_pi_start_high_in_ect = 1,

View File

@@ -66,6 +66,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};
@@ -128,6 +130,8 @@ static const struct mb_cfg hynix_memconfig = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
.cs_pi_start_high_in_ect = 1,

View File

@@ -63,6 +63,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};

View File

@@ -63,6 +63,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = 1, /* Enable Early Command Training */
};

View File

@@ -58,6 +58,8 @@ static const struct mb_cfg baseboard_memcfg = {
.ddr7 = { .dqs0 = 0, .dqs1 = 1 },
},
.LpDdrDqDqsReTraining = 1,
.ect = true, /* Early Command Training */
.UserBd = BOARD_TYPE_ULT_ULX_T4,