soc/intel/apollolake: Fix logical vs. bitwise operator
src/soc/intel/apollolake/chip.c Apply bitwise operator instead of logical one. Found-by: Coverity Scan BRANCH=None TEST=Built & booted Yorp board. Change-Id: I36746b04dec889f53c8d7eeb3b1d8118eff1de42 Signed-off-by: John Zhao <john.zhao@intel.com> Reviewed-on: https://review.coreboot.org/28261 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Lijian Zhao <lijian.zhao@intel.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
@ -678,7 +678,7 @@ static void configure_xhci_host_mode_port0(void)
|
||||
cfg0 = (void *)(uintptr_t)(res->base + DUAL_ROLE_CFG0);
|
||||
cfg1 = (void *)(uintptr_t)(res->base + DUAL_ROLE_CFG1);
|
||||
reg = read32(cfg0);
|
||||
if (!(reg && SW_IDPIN_EN_MASK))
|
||||
if (!(reg & SW_IDPIN_EN_MASK))
|
||||
return;
|
||||
|
||||
reg &= ~(SW_IDPIN_MASK | SW_VBUS_VALID_MASK);
|
||||
|
Reference in New Issue
Block a user