sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brox/var/brox: Remove mux references from typec port

Browse Source 
The Type-C kernel driver no longer programs the AP mux, as of
https://review.coreboot.org/c/coreboot/+/82077. So remove device
references to the TCSS Mux control device from the Type-C port driver.

This eliminates the following kernel error which was observed as a
result of the kernel trying to program muxes it no longer has control
over:

[    4.618600] cros-ec-typec GOOG0014:00: Failed to get mux info for port: 0, err = -95
[    4.618608] cros-ec-typec GOOG0014:00: Configure muxes failed, err = -95

BUG=b:341331428
TEST=Run system reboot; configure mux kernel errors no longer seen.

Change-Id: I93e498b12b109c0e649a23a4a49868976a9ee06b
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82599
Reviewed-by: Caveh Jalali <caveh@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Prashant Malani 2024-05-21 16:09:57 -07:00 committed by Felix Held
parent fe8323b7b6
commit e3fbd2a958
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/brox/variants/brox/overridetree.cb
View File

@ -138,8 +138,6 @@ chip soc/intel/alderlake
end # Integrated Graphics Device
device ref pch_espi on
chip ec/google/chromeec
use conn0 as mux_conn[0]
use conn1 as mux_conn[1]
device pnp 0c09.0 on end
end
end
@ -149,12 +147,12 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux/conn
use usb2_port1 as usb2_port
use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
device generic 0 on end
end
chip drivers/intel/pmc_mux/conn
use usb2_port3 as usb2_port
use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
device generic 1 on end
end
end
end