sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/*: Set VR12 PSI to fix crash

Browse Source 
When in Package C3 or deeper the PSI settings are used to switch the
CPU VR into a low power state. It was found that the voltage regulator
on the Sandy-Bridge series has non-default PSI settings, compared to
Lenovo's Ivy-Bridge series. Apply the same PSI value for PSI2 and PSI3
as the vendor BIOS does to fix a hang when the package is idle.

Since neither the vendor BIOS is open-source, nor datasheet exists for
the used VR it's unclear why those PSI values must be used and how
they influence the regulator.

The X220 already has the correct PSI values configured and is now stable
for more than 24h in Package C7 state.

TEST: Not tested on the affected boards, only checked vendor firmware.

Change-Id: Idf8c3719f19f7bcdab30c543215c8abd2669cfd2
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82070
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Patrick Rudolph 2024-04-28 11:18:43 +02:00 committed by Felix Held
parent 2de0e87622
commit e4b2f3a6a2
4 changed files with 32 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mainboard/lenovo/l520/devicetree.cb
View File

@ -12,7 +12,14 @@ chip northbridge/intel/sandybridge
register "gpu_panel_power_up_delay" = "0"
register "gpu_pch_backlight" = "0x00000000"
register "spd_addresses" = "{0x50, 0, 0x52, 0}"
chip cpu/intel/model_206ax
# Values obtained from vendor BIOS
register "pp0_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp0_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
register "pp1_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp1_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
device cpu_cluster 0 on end
end
device domain 0 on
subsystemid 0x17aa 0x21dd inherit

9
src/mainboard/lenovo/t420/devicetree.cb
View File

@ -16,7 +16,14 @@ chip northbridge/intel/sandybridge
register "gpu_pch_backlight" = "0x06100610"
register "spd_addresses" = "{0x50, 0, 0x51, 0}"
chip cpu/intel/model_206ax
# Values obtained from vendor BIOS
register "pp0_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp0_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
register "pp1_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp1_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
device cpu_cluster 0 on end
end
device domain 0 on
subsystemid 0x17aa 0x21ce inherit

9
src/mainboard/lenovo/t420s/devicetree.cb
View File

@ -16,7 +16,14 @@ chip northbridge/intel/sandybridge
register "gpu_pch_backlight" = "0x06100610"
register "spd_addresses" = "{0x50, 0, 0x51, 0}"
chip cpu/intel/model_206ax
# Values obtained from vendor BIOS
register "pp0_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp0_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
register "pp1_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp1_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
device cpu_cluster 0 on end
end
device domain 0 on
subsystemid 0x17aa 0x21d2 inherit

8
src/mainboard/lenovo/t520/devicetree.cb
View File

@ -15,6 +15,14 @@ chip northbridge/intel/sandybridge
register "gpu_cpu_backlight" = "0x1155"
register "gpu_pch_backlight" = "0x06100610"
chip cpu/intel/model_206ax
# Values obtained from vendor BIOS
register "pp0_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp0_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
register "pp1_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp1_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
device cpu_cluster 0 on end
end
device domain 0 on
subsystemid 0x17aa 0x21cf inherit