soc/intel/{cnl,icl,skl,tgl,common}: Make changes to send_heci_reset_req_message()
Below changes have been implemented in send_heci_reset_req_message(): 1. Modify return values to align with other functions in the same file. 2. Add additional logging. 3. Replace macro definitions of reset types with ENUM. 4. Make changes to caller functions to sync with new return values. 5. Rename send_heci_reset_req_message() to cse_request_global_reset(). Test=Verified on hatch board. Change-Id: I979b169a5bb3a5d4028ef030bcef2b8eeffe86e3 Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37584 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
committed by
Patrick Georgi
parent
63be9181cb
commit
f2eb687d19
@@ -441,7 +441,7 @@ int send_global_reset(void)
|
||||
goto ret;
|
||||
|
||||
/* ME should be in Normal Mode for this command */
|
||||
status = send_heci_reset_req_message(GLOBAL_RESET);
|
||||
status = cse_request_global_reset(GLOBAL_RESET);
|
||||
ret:
|
||||
return status;
|
||||
}
|
||||
|
@@ -37,7 +37,7 @@ static void do_force_global_reset(void)
|
||||
|
||||
void do_global_reset(void)
|
||||
{
|
||||
if (send_global_reset() != 0) {
|
||||
if (!send_global_reset()) {
|
||||
/* If ME unable to reset platform then
|
||||
* force global reset using PMC CF9GR register*/
|
||||
do_force_global_reset();
|
||||
|
Reference in New Issue
Block a user