mb/system76: Set PrimaryDisplay to hybrid graphics

Use the FSP option for (muxless) hybrid graphics. Internally it ends up
setting PrimaryDisplay to iGFX, but does some extra configuration for
the dGPU.

Only galp5 is left as setting PrimaryDisplay to iGFX as the dGPU was
optional for the model and I don't know what effect it would have to set
it to hybrid for those.

Change-Id: I24c5bc154df127fc5c16a388fc7ae4316167ba70
Signed-off-by: Tim Crawford <tcrawford@system76.com>

src/drivers/gfx/nvidia/nvidia.c

@@ -66,6 +66,6 @@ static void nvidia_enable(struct device *dev)
 }
 
 struct chip_operations drivers_gfx_nvidia_ops = {
-	.name = "NVIDIA Optimus Graphics Device",
+	CHIP_NAME("NVIDIA Optimus Graphics Device")
 	.enable_dev = nvidia_enable
 };

src/drivers/intel/dtbt/dtbt.c

@@ -64,10 +64,11 @@ static void dtbt_fill_ssdt(const struct device *dev)
 	}
 	printk(BIOS_DEBUG, "  Dev %s\n", dev_path(dev));
 
-	struct bus *bus = dev->upstream;
+	struct bus *bus = dev->bus;
 	if (!bus) {
 		printk(BIOS_ERR, "DTBT bus invalid\n");
 	}
+	printk(BIOS_DEBUG, "  Bus %s\n", bus_path(bus));
 
 	struct device *parent = bus->dev;
 	if (!parent || parent->path.type != DEVICE_PATH_PCI) {
@@ -209,6 +210,6 @@ static void dtbt_enable(struct device *dev)
 }
 
 struct chip_operations drivers_intel_dtbt_ops = {
-	.name = "Intel Discrete Thunderbolt Device",
+	CHIP_NAME("Intel Discrete Thunderbolt Device")
 	.enable_dev = dtbt_enable
 };

src/lib/rtc.c

@@ -126,7 +126,7 @@ static int rtc_month_days(unsigned int month, unsigned int year)
 {
 	int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
 
-	return month_days[month] + (LEAP_YEAR(year) && month == 1);
+	return month_days[month] + (LEAP_YEAR(year) && month == 2);
 }
 
 int rtc_invalid(const struct rtc_time *tm)

src/mainboard/system76/addw1/romstage.c

@@ -31,8 +31,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	memupd->FspmConfig.PrimaryDisplay = 0;
+	memupd->FspmConfig.PrimaryDisplay = 4;
 
 	cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg);
 }

src/mainboard/system76/adl/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/adl/acpi/mainboard.asl

@@ -11,6 +11,8 @@
 Scope (\_SB) {
 	#include "sleep.asl"
 	Scope (PCI0) {
+		#include "backlight.asl"
+
 #if CONFIG(DRIVERS_GFX_NVIDIA)
 		Scope (PEG2) {
 			#include <drivers/gfx/nvidia/acpi/tigerlake.asl>

src/mainboard/system76/adl/devicetree.cb

@@ -81,7 +81,6 @@ chip soc/intel/alderlake
 		end
 		device ref p2sb on end
 		device ref hda on
-			register "pch_hda_sdi_enable[0]" = "1"
 			register "pch_hda_audio_link_hda_enable" = "1"
 			register "pch_hda_idisp_codec_enable" = "1"
 			register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"

src/mainboard/system76/adl/dsdt.asl

@@ -20,7 +20,6 @@ DefinitionBlock(
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/alderlake/acpi/southbridge.asl>
 		#include <soc/intel/alderlake/acpi/tcss.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/adl/variants/darp8/overridetree.cb

@@ -154,7 +154,6 @@ chip soc/intel/alderlake
 				.clk_src = 4,
 				.clk_req = 4,
 				.flags = PCIE_RP_LTR,
-				.pcie_rp_detect_timeout_ms = 50,
 			}"
 			# FIXME: Drives do not exit D3cold on S3 exit
 			#chip soc/intel/common/block/pcie/rtd3

src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb

@@ -102,7 +102,6 @@ chip soc/intel/alderlake
 				.clk_src = 1,
 				.clk_req = 1,
 				.flags = PCIE_RP_LTR,
-				.pcie_rp_detect_timeout_ms = 50,
 			}"
 		end
 		device ref pcie_rp9 on

src/mainboard/system76/adl/variants/gaze17-3050/romstage.c

@@ -27,8 +27,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;

src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb

@@ -134,7 +134,6 @@ chip soc/intel/alderlake
 				.clk_src = 1,
 				.clk_req = 1,
 				.flags = PCIE_RP_LTR,
-				.pcie_rp_detect_timeout_ms = 50,
 			}"
 		end
 		device ref gbe on end

src/mainboard/system76/adl/variants/gaze17-3060-b/romstage.c

@@ -27,8 +27,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;

src/mainboard/system76/adl/variants/lemp11/overridetree.cb

@@ -138,7 +138,6 @@ chip soc/intel/alderlake
 				.clk_src = 1,
 				.clk_req = 1,
 				.flags = PCIE_RP_LTR,
-				.pcie_rp_detect_timeout_ms = 50,
 			}"
 			# FIXME: Drives do not exit D3cold on S3 exit
 			#chip soc/intel/common/block/pcie/rtd3

src/mainboard/system76/adl/variants/lemp11/romstage.c

@@ -15,6 +15,7 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	};
 	const bool half_populated = false;
 
+	mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;
 

src/mainboard/system76/adl/variants/oryp10/romstage.c

@@ -30,9 +30,10 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
+	mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;
 

src/mainboard/system76/adl/variants/oryp9/romstage.c

@@ -27,9 +27,10 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
+	mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;
 

src/mainboard/system76/cml-u/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/cml-u/acpi/mainboard.asl

@@ -6,6 +6,9 @@
 
 Scope (\_SB) {
 	#include "sleep.asl"
+	Scope (PCI0) {
+		#include "backlight.asl"
+	}
 }
 
 Scope (\_GPE) {

src/mainboard/system76/cml-u/dsdt.asl

@@ -19,7 +19,6 @@ DefinitionBlock(
 	{
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/cannonlake/acpi/southbridge.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/gaze15/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/gaze15/acpi/mainboard.asl

@@ -9,6 +9,7 @@
 Scope (\_SB) {
 	#include "sleep.asl"
 	Scope (PCI0) {
+		#include "backlight.asl"
 		Device (PEGP) {
 			Name (_ADR, CONFIG_DRIVERS_GFX_NVIDIA_BRIDGE << 16)
 			#include <drivers/gfx/nvidia/acpi/coffeelake.asl>

src/mainboard/system76/gaze15/dsdt.asl

@@ -18,7 +18,6 @@ DefinitionBlock(
 	Device (\_SB.PCI0) {
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/cannonlake/acpi/southbridge.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/gaze15/romstage.c

@@ -31,8 +31,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	memupd->FspmConfig.PrimaryDisplay = 0;
+	memupd->FspmConfig.PrimaryDisplay = 4;
 
 	cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg);
 }

src/mainboard/system76/kbl-u/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/kbl-u/acpi/mainboard.asl

@@ -1,6 +1,10 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
 Scope (\_SB) {
+	Scope (PCI0) {
+		#include "backlight.asl"
+	}
+
 	#include "ac.asl"
 	#include "battery.asl"
 	#include "buttons.asl"

src/mainboard/system76/kbl-u/dsdt.asl

@@ -19,7 +19,6 @@ DefinitionBlock(
 	{
 		#include <soc/intel/skylake/acpi/systemagent.asl>
 		#include <soc/intel/skylake/acpi/pch.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/oryp5/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/oryp5/acpi/mainboard.asl

@@ -10,6 +10,7 @@ Scope (\_SB)
 {
 	#include "sleep.asl"
 	Scope (PCI0) {
+		#include "backlight.asl"
 		Device (PEGP) {
 			Name (_ADR, CONFIG_DRIVERS_GFX_NVIDIA_BRIDGE << 16)
 			#include <drivers/gfx/nvidia/acpi/coffeelake.asl>

src/mainboard/system76/oryp5/dsdt.asl

@@ -19,7 +19,6 @@ DefinitionBlock(
 	{
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/cannonlake/acpi/southbridge.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/oryp5/romstage.c

@@ -31,8 +31,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	memupd->FspmConfig.PrimaryDisplay = 0;
+	memupd->FspmConfig.PrimaryDisplay = 4;
 
 	// Allow memory speeds higher than 2666 MT/s
 	memupd->FspmConfig.SaOcSupport = 1;

src/mainboard/system76/oryp6/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/oryp6/acpi/mainboard.asl

@@ -9,6 +9,7 @@
 Scope (\_SB) {
 	#include "sleep.asl"
 	Scope (PCI0) {
+		#include "backlight.asl"
 		Device (PEGP) {
 			Name (_ADR, CONFIG_DRIVERS_GFX_NVIDIA_BRIDGE << 16)
 			#include <drivers/gfx/nvidia/acpi/coffeelake.asl>

src/mainboard/system76/oryp6/dsdt.asl

@@ -18,7 +18,6 @@ DefinitionBlock(
 	Device (\_SB.PCI0) {
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/cannonlake/acpi/southbridge.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/oryp6/romstage.c

@@ -32,8 +32,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	memupd->FspmConfig.PrimaryDisplay = 0;
+	memupd->FspmConfig.PrimaryDisplay = 4;
 
 	variant_configure_fspm(memupd);
 

src/mainboard/system76/rpl/Kconfig

@@ -36,14 +36,6 @@ config BOARD_SYSTEM76_ADDW3
 	select PCIEXP_HOTPLUG
 	select SOC_INTEL_ALDERLAKE_PCH_S
 
-config BOARD_SYSTEM76_ADDW4
-	select BOARD_SYSTEM76_RPL_COMMON
-	select DRIVERS_GFX_NVIDIA
-	select DRIVERS_GFX_NVIDIA_DYNAMIC_BOOST
-	select EC_SYSTEM76_EC_DGPU
-	select PCIEXP_HOTPLUG
-	select SOC_INTEL_ALDERLAKE_PCH_S
-
 config BOARD_SYSTEM76_BONW15
 	select BOARD_SYSTEM76_RPL_COMMON
 	select DRIVERS_GFX_NVIDIA
@@ -100,7 +92,6 @@ config MAINBOARD_DIR
 
 config VARIANT_DIR
 	default "addw3" if BOARD_SYSTEM76_ADDW3
-	default "addw4" if BOARD_SYSTEM76_ADDW4
 	default "bonw15" if BOARD_SYSTEM76_BONW15
 	default "darp9" if BOARD_SYSTEM76_DARP9
 	default "galp7" if BOARD_SYSTEM76_GALP7
@@ -114,7 +105,6 @@ config OVERRIDE_DEVICETREE
 
 config MAINBOARD_PART_NUMBER
 	default "addw3" if BOARD_SYSTEM76_ADDW3
-	default "addw4" if BOARD_SYSTEM76_ADDW4
 	default "bonw15" if BOARD_SYSTEM76_BONW15
 	default "darp9" if BOARD_SYSTEM76_DARP9
 	default "galp7" if BOARD_SYSTEM76_GALP7
@@ -124,7 +114,7 @@ config MAINBOARD_PART_NUMBER
 	default "serw13" if BOARD_SYSTEM76_SERW13
 
 config MAINBOARD_SMBIOS_PRODUCT_NAME
-	default "Adder WS" if BOARD_SYSTEM76_ADDW3 || BOARD_SYSTEM76_ADDW4
+	default "Adder WS" if BOARD_SYSTEM76_ADDW3
 	default "Bonobo WS" if BOARD_SYSTEM76_BONW15
 	default "Darter Pro" if BOARD_SYSTEM76_DARP9
 	default "Galago Pro" if BOARD_SYSTEM76_GALP7
@@ -135,7 +125,6 @@ config MAINBOARD_SMBIOS_PRODUCT_NAME
 
 config MAINBOARD_VERSION
 	default "addw3" if BOARD_SYSTEM76_ADDW3
-	default "addw4" if BOARD_SYSTEM76_ADDW4
 	default "bonw15" if BOARD_SYSTEM76_BONW15
 	default "darp9" if BOARD_SYSTEM76_DARP9
 	default "galp7" if BOARD_SYSTEM76_GALP7
@@ -162,11 +151,11 @@ config DRIVERS_GFX_NVIDIA_BRIDGE
 
 config DRIVERS_GFX_NVIDIA_DYNAMIC_BOOST_TPP
 	default 45 if BOARD_SYSTEM76_ORYP11
-	default 55 if BOARD_SYSTEM76_ADDW3 || BOARD_SYSTEM76_ADDW4 || BOARD_SYSTEM76_GAZE18 || BOARD_SYSTEM76_SERW13
+	default 55 if BOARD_SYSTEM76_ADDW3 || BOARD_SYSTEM76_GAZE18 || BOARD_SYSTEM76_SERW13
 	default 80 if BOARD_SYSTEM76_BONW15
 
 config DRIVERS_GFX_NVIDIA_DYNAMIC_BOOST_MAX
-	default 25 if BOARD_SYSTEM76_ADDW3 || BOARD_SYSTEM76_ADDW4 || BOARD_SYSTEM76_BONW15 || BOARD_SYSTEM76_GAZE18 || BOARD_SYSTEM76_ORYP11 || BOARD_SYSTEM76_SERW13
+	default 25 if BOARD_SYSTEM76_ADDW3 || BOARD_SYSTEM76_BONW15 || BOARD_SYSTEM76_GAZE18 || BOARD_SYSTEM76_ORYP11 || BOARD_SYSTEM76_SERW13
 
 config FMDFILE
 	default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/variants/\$(CONFIG_VARIANT_DIR)/board.fmd"

src/mainboard/system76/rpl/Kconfig.name

@@ -3,9 +3,6 @@
 config BOARD_SYSTEM76_ADDW3
 	bool "addw3"
 
-config BOARD_SYSTEM76_ADDW4
-	bool "addw4"
-
 config BOARD_SYSTEM76_BONW15
 	bool "bonw15"
 

src/mainboard/system76/rpl/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/rpl/acpi/mainboard.asl

@@ -11,6 +11,8 @@
 Scope (\_SB) {
 	#include "sleep.asl"
 	Scope (PCI0) {
+		#include "backlight.asl"
+
 #if CONFIG(DRIVERS_GFX_NVIDIA)
 #if CONFIG(SOC_INTEL_ALDERLAKE_PCH_P) || CONFIG(BOARD_SYSTEM76_BONW15)
 		Scope (PEG2) {

src/mainboard/system76/rpl/devicetree.cb

@@ -53,7 +53,7 @@ chip soc/intel/alderlake
 			register "sata_salp_support" = "1"
 			register "sata_ports_enable[1]" = "1" # SSD1
 			# FIXME: DevSlp breaks S0ix
-			#register "sata_ports_dev_slp[1]" = "1"
+			#register "sata_ports_dev_slp[1]" = "1" # GPP_H12 (SATA1_DEVSLP1)
 		end
 		device ref pch_espi on
 			register "gen1_dec" = "0x00040069" # EC PM channel
@@ -65,7 +65,6 @@ chip soc/intel/alderlake
 		end
 		device ref p2sb on end
 		device ref hda on
-			register "pch_hda_sdi_enable[0]" = "1"
 			register "pch_hda_audio_link_hda_enable" = "1"
 			register "pch_hda_idisp_codec_enable" = "1"
 			register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"

src/mainboard/system76/rpl/dsdt.asl

@@ -19,8 +19,9 @@ DefinitionBlock(
 	{
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/alderlake/acpi/southbridge.asl>
-		#include <soc/intel/alderlake/acpi/tcss.asl>
+		#if CONFIG(BOARD_SYSTEM76_ORYP11)
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
+			#include <soc/intel/alderlake/acpi/tcss.asl>
+		#endif // CONFIG(BOARD_SYSTEM76_ORYP11)
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/rpl/variants/addw3/romstage.c

@@ -33,8 +33,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;

src/mainboard/system76/rpl/variants/addw4/board.fmd

@@ -1,12 +0,0 @@
-FLASH 32M {
-	SI_DESC 4K
-	SI_ME 3944K
-	SI_BIOS@16M 16M {
-		RW_MRC_CACHE 64K
-		SMMSTORE(PRESERVE) 256K
-		WP_RO {
-			FMAP 4K
-			COREBOOT(CBFS)
-		}
-	}
-}

src/mainboard/system76/rpl/variants/addw4/board_info.txt

@@ -1,2 +0,0 @@
-Board name: addw4
-Release year: 2024

src/mainboard/system76/rpl/variants/addw4/gpio.c

@@ -1,294 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <mainboard/gpio.h>
-#include <soc/gpio.h>
-
-static const struct pad_config gpio_table[] = {
-	/* ------- GPIO Group GPD ------- */
-	PAD_CFG_NF(GPD0, UP_20K, PWROK, NF1), // BATLOW#
-	PAD_CFG_NF(GPD1, NATIVE, PWROK, NF1), // AC_PRESENT
-	PAD_NC(GPD2, NONE),
-	PAD_CFG_NF(GPD3, UP_20K, PWROK, NF1), // PWR_BTN#
-	PAD_CFG_NF(GPD4, NONE, PWROK, NF1), // SUSB#_PCH
-	PAD_CFG_NF(GPD5, NONE, PWROK, NF1), // SUSC#_PCH
-	PAD_NC(GPD6, NONE),
-	PAD_NC(GPD7, NONE),
-	PAD_CFG_NF(GPD8, NONE, PWROK, NF1), // CNVI_SUSCLK
-	PAD_CFG_GPO(GPD9, 0, PWROK), // SLP_WLAN#
-	PAD_NC(GPD10, NONE),
-	PAD_NC(GPD11, NONE),
-	PAD_NC(GPD12, NONE),
-
-	/* ------- GPIO Group GPP_A ------- */
-	PAD_CFG_NF(GPP_A0, UP_20K, DEEP, NF1), // ESPI_IO0_EC
-	PAD_CFG_NF(GPP_A1, UP_20K, DEEP, NF1), // ESPI_IO1_EC
-	PAD_CFG_NF(GPP_A2, UP_20K, DEEP, NF1), // ESPI_IO2_EC
-	PAD_CFG_NF(GPP_A3, UP_20K, DEEP, NF1), // ESPI_IO3_EC
-	PAD_CFG_NF(GPP_A4, UP_20K, DEEP, NF1), // ESPI_CS_EC#
-	PAD_CFG_NF(GPP_A5, DN_20K, DEEP, NF1), // ESPI_CLK_EC
-	PAD_CFG_NF(GPP_A6, NONE, DEEP, NF1), // ESPI_RESET#
-	PAD_NC(GPP_A7, NONE),
-	PAD_NC(GPP_A8, NONE),
-	PAD_NC(GPP_A9, NONE),
-	PAD_CFG_NF(GPP_A10, UP_20K, DEEP, NF1), // ESPI_ALRT0#
-	PAD_CFG_GPI(GPP_A11, UP_20K, DEEP), // GPIO4_GC6_NVVDD_EN_R
-	PAD_NC(GPP_A12, NONE),
-	PAD_NC(GPP_A13, NONE),
-	PAD_NC(GPP_A14, NONE),
-
-	/* ------- GPIO Group GPP_B ------- */
-	_PAD_CFG_STRUCT(GPP_B0, 0x40100100, 0x3000), // TPM_PIRQ#
-	PAD_NC(GPP_B1, NONE),
-	PAD_CFG_GPI(GPP_B2, NONE, DEEP), // CNVI_WAKE#
-	PAD_CFG_GPO(GPP_B3, 1, PLTRST), // BT_EN
-	PAD_NC(GPP_B4, NONE),
-	PAD_NC(GPP_B5, NONE),
-	PAD_NC(GPP_B6, NONE),
-	PAD_NC(GPP_B7, NONE),
-	PAD_NC(GPP_B8, NONE),
-	PAD_NC(GPP_B9, NONE),
-	PAD_NC(GPP_B10, NONE),
-	PAD_NC(GPP_B11, NONE),
-	PAD_NC(GPP_B12, NONE),
-	PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), // PLT_RST#
-	PAD_CFG_NF(GPP_B14, NONE, DEEP, NF1), // HDA_SPKR
-	PAD_NC(GPP_B15, NONE),
-	PAD_NC(GPP_B16, NONE),
-	PAD_NC(GPP_B17, NONE),
-	PAD_CFG_NF(GPP_B18, NONE, PWROK, NF1), // GPP_B18_PMCALERT#
-	PAD_NC(GPP_B19, NONE),
-	PAD_CFG_GPO(GPP_B20, 0, DEEP), // GPIO_LANRTD3
-	PAD_NC(GPP_B21, NONE),
-	PAD_NC(GPP_B22, NONE),
-	PAD_CFG_GPI(GPP_B23, NONE, DEEP), // Crystal freq strap
-
-	/* ------- GPIO Group GPP_C ------- */
-	PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), // SMB_CLK
-	PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), // SMB_DATA
-	PAD_CFG_GPI(GPP_C2, NONE, DEEP), // TLS confidentiality strap
-	PAD_CFG_NF(GPP_C3, NONE, DEEP, NF3), // I2C2_SDA (Pantone)
-	PAD_CFG_NF(GPP_C4, NONE, DEEP, NF3), // I2C2_SCL (Pantone)
-	PAD_NC(GPP_C5, NONE), // eSPI disable strap
-	PAD_CFG_NF(GPP_C6, NONE, DEEP, NF2), // SMD_7411
-	PAD_CFG_NF(GPP_C7, NONE, DEEP, NF2), // SMC_7411
-	PAD_CFG_GPI(GPP_C8, NONE, DEEP), // TPM_DET
-	PAD_NC(GPP_C9, NONE),
-	PAD_CFG_GPO(GPP_C10, 0, DEEP), // TEST_R (ANX7411)
-	PAD_CFG_GPO(GPP_C11, 0, DEEP), // PCH_TEST_R_2 (ANX7411)
-	PAD_NC(GPP_C12, NONE),
-	PAD_NC(GPP_C13, NONE),
-	PAD_NC(GPP_C14, NONE),
-	PAD_NC(GPP_C15, NONE),
-	PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), // I2C_SDA_TP
-	PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), // I2C_SCL_TP
-	PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), // SMD_7411_2
-	PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), // SMC_7411_2
-	// GPP_C20 (UART2_RXD) configured in bootblock
-	// GPP_C21 (UART2_TXD) configured in bootblock
-	PAD_NC(GPP_C22, NONE),
-	PAD_NC(GPP_C23, NONE),
-
-	/* ------- GPIO Group GPP_D ------- */
-	PAD_NC(GPP_D0, NONE),
-	PAD_NC(GPP_D1, NONE),
-	PAD_NC(GPP_D2, NONE),
-	PAD_CFG_GPO(GPP_D3, 0, DEEP), // GFX_DETECT_STRAP
-	PAD_NC(GPP_D4, NONE),
-	PAD_CFG_GPO(GPP_D5, 1, DEEP), // M.2_BT_PCMFRM_CRF_RST_N
-	// GPP_D6 (M.2_BT_PCMOUT_CLKREQ0) configured by FSP
-	PAD_NC(GPP_D7, NONE),
-	PAD_NC(GPP_D8, NONE),
-	PAD_NC(GPP_D9, NONE),
-	PAD_NC(GPP_D10, NONE),
-	PAD_NC(GPP_D11, NONE),
-	// GPP_D12 (SSD2_CLKREQ#) configured by FSP
-	PAD_NC(GPP_D13, NONE),
-	PAD_NC(GPP_D14, NONE),
-	PAD_NC(GPP_D15, NONE),
-	PAD_NC(GPP_D16, NONE),
-	PAD_NC(GPP_D17, NONE),
-	PAD_NC(GPP_D18, NONE),
-	PAD_NC(GPP_D19, NONE),
-	PAD_NC(GPP_D20, NONE),
-	PAD_NC(GPP_D21, NONE),
-	PAD_NC(GPP_D22, NONE),
-	PAD_NC(GPP_D23, NONE),
-
-	/* ------- GPIO Group GPP_E ------- */
-	PAD_NC(GPP_E0, NONE),
-	PAD_NC(GPP_E1, NONE),
-	PAD_CFG_GPI(GPP_E2, NONE, DEEP), // SWI#
-	PAD_NC(GPP_E3, NONE),
-	PAD_NC(GPP_E4, NONE),
-	PAD_NC(GPP_E5, NONE),
-	PAD_NC(GPP_E6, NONE),
-	PAD_CFG_GPI_INT(GPP_E7, NONE, PLTRST, LEVEL), // TP_ATTN#
-	PAD_CFG_NF(GPP_E8, NONE, DEEP, NF1), // SATA_LED#
-	PAD_CFG_GPI(GPP_E9, NONE, DEEP), // USB_OC0#
-	PAD_CFG_GPI(GPP_E10, NONE, DEEP), // USB_OC1#
-	PAD_CFG_GPI(GPP_E11, NONE, DEEP), // USB_OC2#
-	PAD_CFG_GPI(GPP_E12, NONE, DEEP), // USB_OC3#
-	PAD_NC(GPP_E13, NONE),
-	PAD_NC(GPP_E14, NONE),
-	PAD_NC(GPP_E15, NONE),
-	PAD_NC(GPP_E16, NONE),
-	PAD_CFG_GPI(GPP_E17, NONE, DEEP), // SB_KBCRST#
-	PAD_CFG_GPO(GPP_E18, 1, DEEP), // SB_BLON
-	PAD_NC(GPP_E19, NONE),
-	PAD_NC(GPP_E20, NONE),
-	PAD_NC(GPP_E21, NONE),
-
-	/* ------- GPIO Group GPP_F ------- */
-	PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), // M.2_SSD_SATA_DET_N
-	PAD_NC(GPP_F1, NONE),
-	PAD_NC(GPP_F2, NONE),
-	PAD_NC(GPP_F3, NONE),
-	PAD_NC(GPP_F4, NONE),
-	PAD_CFG_NF(GPP_F5, NONE, DEEP, NF1), // SSD_SATA_DEVSLP
-	PAD_NC(GPP_F6, NONE),
-	_PAD_CFG_STRUCT(GPP_F7, 0x80100100, 0x0000), // 7411_INTP_OUT
-	PAD_NC(GPP_F8, NONE),
-	// GPP_F9 (DGPU_PWR_EN) configured in bootblock
-	PAD_CFG_GPI(GPP_F10, NONE, DEEP), // Recovery strap
-	PAD_NC(GPP_F11, NONE),
-	PAD_NC(GPP_F12, NONE),
-	PAD_NC(GPP_F13, NONE),
-	PAD_NC(GPP_F14, NONE),
-	PAD_CFG_GPI(GPP_F15, NONE, DEEP), // H_SKTOCC_N
-	_PAD_CFG_STRUCT(GPP_F16, 0x80100100, 0x0000), // INTP_OUT
-	PAD_NC(GPP_F17, NONE),
-	PAD_CFG_GPO(GPP_F18, 0, DEEP), // CCD_WP#
-	PAD_CFG_NF(GPP_F19, NONE, DEEP, NF1), // NB_ENAVDD
-	PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), // BLON
-	PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), // EDP_BRIGHTNESS
-	PAD_NC(GPP_F22, NONE),
-	PAD_NC(GPP_F23, NONE),
-
-	/* ------- GPIO Group GPP_G ------- */
-	PAD_CFG_GPO(GPP_G0, 0, DEEP), // Board ID 2
-	PAD_CFG_GPO(GPP_G1, 0, DEEP), // Board ID 3
-	PAD_NC(GPP_G2, NONE),
-	PAD_CFG_GPI(GPP_G3, NONE, DEEP), // MB detect GN20/GN21
-	PAD_CFG_GPI(GPP_G4, NONE, DEEP), // Board ID 1
-	PAD_NC(GPP_G5, NONE),
-	PAD_CFG_GPI(GPP_G6, NONE, DEEP), // MB detect G-SYNC
-	PAD_CFG_GPI(GPP_G7, NONE, DEEP), // MB detect 230W/180W adapter
-
-	/* ------- GPIO Group GPP_H ------- */
-	PAD_CFG_GPI(GPP_H0, NONE, DEEP), // VAL_SV_ADVANCE_STRAP
-	PAD_CFG_GPO(GPP_H1, 0, DEEP), // Pantone detect
-	PAD_CFG_GPI(GPP_H2, NONE, DEEP), // WLAN_GPIO_WAKE_N
-	// GPP_H3 (NC) configured by FSP
-	// GPP_H4 (SSD1_SATA_CLKREQ#) configured by FSP
-	// GPP_H5 (WLAN_CLKREQ#) configured by FSP
-	// GPP_H6 (NC) configured by FSP
-	// GPP_H7 (LAN_CLKREQ#) configured by FSP
-	// GPP_H8 (PEG_CLKREQ#) configured by FSP
-	// GPP_H9 (SSD3_CLKREQ#) configured by FSP
-	PAD_NC(GPP_H10, NONE),
-	PAD_NC(GPP_H11, NONE),
-	PAD_NC(GPP_H12, NONE),
-	PAD_NC(GPP_H13, NONE),
-	PAD_NC(GPP_H14, NONE),
-	PAD_CFG_GPO(GPP_H15, 0, DEEP), // JTAG ODT strap
-	PAD_NC(GPP_H16, NONE),
-	PAD_NC(GPP_H17, NONE),
-	PAD_CFG_GPO(GPP_H18, 0, DEEP), // 1.8V VCCPSPI strap
-	PAD_NC(GPP_H19, NONE),
-	PAD_NC(GPP_H20, NONE),
-	PAD_NC(GPP_H21, NONE),
-	PAD_NC(GPP_H22, NONE),
-	PAD_NC(GPP_H23, NONE),
-
-	/* ------- GPIO Group GPP_I ------- */
-	PAD_NC(GPP_I0, NONE),
-	PAD_CFG_NF(GPP_I1, NONE, DEEP, NF1), // DP_HPD
-	PAD_CFG_NF(GPP_I2, NONE, DEEP, NF1), // HDMI_HPD
-	PAD_NC(GPP_I3, NONE),
-	PAD_NC(GPP_I4, NONE),
-	PAD_NC(GPP_I5, NONE),
-	PAD_NC(GPP_I6, NONE),
-	PAD_NC(GPP_I7, NONE),
-	PAD_NC(GPP_I8, NONE),
-	PAD_NC(GPP_I9, NONE),
-	PAD_NC(GPP_I10, NONE),
-	PAD_CFG_GPI(GPP_I11, NONE, DEEP), // USB_OC4#
-	PAD_CFG_GPI(GPP_I12, NONE, DEEP), // USB_OC5#
-	PAD_CFG_GPI(GPP_I13, NONE, DEEP), // USB_OC6#
-	PAD_CFG_GPI(GPP_I14, NONE, DEEP), // USB_OC7#
-	PAD_NC(GPP_I15, NONE),
-	PAD_NC(GPP_I16, NONE),
-	PAD_NC(GPP_I17, NONE),
-	PAD_CFG_GPO(GPP_I18, 0, DEEP), // No reboot strap
-	PAD_NC(GPP_I19, NONE),
-	PAD_NC(GPP_I20, NONE),
-	PAD_NC(GPP_I21, NONE),
-	PAD_CFG_GPO(GPP_I22, 0, DEEP), // Boot BIOS strap
-
-	/* ------- GPIO Group GPP_J ------- */
-	PAD_CFG_NF(GPP_J0, NONE, DEEP, NF1), // CNVI_GNSS_PA_BLANKING
-	PAD_CFG_NF(GPP_J1, NONE, DEEP, NF1), // CPU_C10_GATE#
-	PAD_CFG_NF(GPP_J2, NONE, DEEP, NF1), // CNVI_BRI_DT_R / Xtal freq strap
-	PAD_CFG_NF(GPP_J3, UP_20K, DEEP, NF1), // CNVI_BRI_RSP
-	PAD_CFG_NF(GPP_J4, NONE, DEEP, NF1), // CNVI_RGI_DT_R / M.2 CNV modes strap
-	PAD_CFG_NF(GPP_J5, UP_20K, DEEP, NF1), // CNVI_RGI_RSP
-	PAD_CFG_NF(GPP_J6, NONE, DEEP, NF1), // CNVI_MFUART2_RXD
-	PAD_CFG_NF(GPP_J7, NONE, DEEP, NF1), // CNVI_MFUART2_TXD
-	PAD_CFG_GPI(GPP_J8, NONE, DEEP), // VAL_TEST_SETUP_MENU
-	PAD_NC(GPP_J9, NONE),
-	PAD_NC(GPP_J10, NONE),
-	PAD_NC(GPP_J11, NONE),
-
-	/* ------- GPIO Group GPP_K ------- */
-	PAD_NC(GPP_K0, NONE),
-	PAD_NC(GPP_K1, NONE),
-	PAD_NC(GPP_K2, NONE),
-	PAD_NC(GPP_K3, NONE),
-	PAD_NC(GPP_K4, NONE),
-	PAD_NC(GPP_K5, NONE),
-	// GPP_K6 not in schematics
-	// GPP_K7 not in schematics
-	PAD_CFG_NF(GPP_K8, NONE, DEEP, NF1), // VCCIN_AUX_VID0
-	PAD_CFG_NF(GPP_K9, NONE, DEEP, NF1), // VCCIN_AUX_VID1
-	// GPP_K10 not in schematics
-	PAD_NC(GPP_K11, NONE),
-
-	/* ------- GPIO Group GPP_R ------- */
-	PAD_CFG_NF(GPP_R0, NONE, DEEP, NF1), // HDA_BITCLK
-	PAD_CFG_NF(GPP_R1, NATIVE, DEEP, NF1), // HDA_SYNC
-	PAD_CFG_NF(GPP_R2, NATIVE, DEEP, NF1), // HDA_SDOUT / ME_WE
-	PAD_CFG_NF(GPP_R3, NATIVE, DEEP, NF1), // HDA_SDIN0
-	PAD_CFG_NF(GPP_R4, NONE, DEEP, NF1), // HDA_RST#_R
-	PAD_NC(GPP_R5, NONE),
-	PAD_NC(GPP_R6, NONE),
-	PAD_NC(GPP_R7, NONE),
-	PAD_CFG_GPI(GPP_R8, NONE, DEEP), // DGPU_PWRGD
-	PAD_CFG_NF(GPP_R9, NONE, DEEP, NF1), // EDP_HPD (XXX: NC?)
-	PAD_NC(GPP_R10, NONE),
-	PAD_NC(GPP_R11, NONE),
-	PAD_NC(GPP_R12, NONE),
-	PAD_NC(GPP_R13, NONE),
-	PAD_NC(GPP_R14, NONE),
-	PAD_NC(GPP_R15, NONE),
-	// GPP_R16 (DGPU_RST#_PCH) configured in bootblock
-	PAD_NC(GPP_R17, NONE),
-	PAD_NC(GPP_R18, NONE),
-	PAD_CFG_GPI(GPP_R19, NONE, DEEP), // SCI#
-	PAD_NC(GPP_R20, NONE),
-	PAD_NC(GPP_R21, NONE),
-
-	/* ------- GPIO Group GPP_S ------- */
-	PAD_NC(GPP_S0, NONE),
-	PAD_NC(GPP_S1, NONE),
-	PAD_NC(GPP_S2, NONE),
-	PAD_NC(GPP_S3, NONE),
-	PAD_NC(GPP_S4, NONE),
-	PAD_NC(GPP_S5, NONE),
-	PAD_NC(GPP_S6, NONE),
-	PAD_NC(GPP_S7, NONE),
-};
-
-void mainboard_configure_gpios(void)
-{
-	gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table));
-}

src/mainboard/system76/rpl/variants/addw4/gpio_early.c

@@ -1,16 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <mainboard/gpio.h>
-#include <soc/gpio.h>
-
-static const struct pad_config early_gpio_table[] = {
-	PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), // UART2_RXD
-	PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), // UART2_TXD
-	PAD_CFG_GPO(GPP_F9, 0, DEEP), // DGPU_PWR_EN; XXX: NC?
-	PAD_CFG_GPO(GPP_R16, 0, DEEP), // DGPU_RST#_PCH
-};
-
-void mainboard_configure_early_gpios(void)
-{
-	gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table));
-}

src/mainboard/system76/rpl/variants/addw4/hda_verb.c

@@ -1,52 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <device/azalia_device.h>
-
-const u32 cim_verb_data[] = {
-	/* Realtek, ALC245 */
-	0x10ec0245, /* Vendor ID */
-	0x15580353, /* Subsystem ID */
-	35, /* Number of entries */
-
-	0x02050008, 0x020480cb, 0x02050008, 0x0204c0cb,
-
-	AZALIA_SUBVENDOR(0, 0x15580353),
-	AZALIA_RESET(1),
-	AZALIA_PIN_CFG(0, 0x12, 0x90a60130),
-	AZALIA_PIN_CFG(0, 0x13, 0x40000000),
-	AZALIA_PIN_CFG(0, 0x14, 0x90170110),
-	AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
-	AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
-	AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
-	AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
-	AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
-	AZALIA_PIN_CFG(0, 0x1d, 0x40689b2d),
-	AZALIA_PIN_CFG(0, 0x1e, 0x411111f0),
-	AZALIA_PIN_CFG(0, 0x21, 0x04211020),
-
-	0x05b50006, 0x05b40011, 0x0205001a, 0x0204810b,
-	0x0205004a, 0x02042010, 0x02050038, 0x02047909,
-	0x05c50000, 0x05c43d82, 0x05c50000, 0x05c43d82,
-	0x05350000, 0x0534201a, 0x05350000, 0x0534201a,
-	0x0535001d, 0x05340800, 0x0535001e, 0x05340800,
-	0x05350003, 0x05341ec4, 0x05350004, 0x05340000,
-	0x05450000, 0x05442000, 0x0545001d, 0x05440800,
-	0x0545001e, 0x05440800, 0x05450003, 0x05441ec4,
-	0x05450004, 0x05440000, 0x05350000, 0x0534a01a,
-	0x0205003c, 0x0204f175, 0x0205003c, 0x0204f135,
-	0x02050040, 0x02048800, 0x05a50001, 0x05a4001f,
-	0x02050010, 0x02040020, 0x02050010, 0x02040020,
-	0x0205006b, 0x0204a390, 0x0205006b, 0x0204a390,
-	0x0205006c, 0x02040c9e, 0x0205006d, 0x02040c00,
-	0x00170500, 0x00170500, 0x05a50004, 0x05a40113,
-	0x02050008, 0x02046a8c, 0x02050076, 0x0204f000,
-	0x0205000e, 0x020465c0, 0x02050033, 0x02048580,
-	0x02050069, 0x0204fda8, 0x02050068, 0x02040000,
-	0x02050003, 0x02040002, 0x02050069, 0x02040000,
-	0x02050068, 0x02040001, 0x0205002e, 0x0204290e,
-	0x02050010, 0x02040020, 0x02050010, 0x02040020,
-};
-
-const u32 pc_beep_verbs[] = {};
-
-AZALIA_ARRAY_SIZES;

src/mainboard/system76/rpl/variants/addw4/include/variant/gpio.h

@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#ifndef VARIANT_GPIO_H
-#define VARIANT_GPIO_H
-
-#include <soc/gpio.h>
-
-#define DGPU_RST_N	GPP_R16
-#define DGPU_PWR_EN	GPP_F9
-#define DGPU_SSID	0x03531558
-
-#endif

src/mainboard/system76/rpl/variants/addw4/overridetree.cb

@@ -1,101 +0,0 @@
-chip soc/intel/alderlake
-	# Support 5600 MT/s memory
-	register "max_dram_speed_mts" = "5600"
-
-	device domain 0 on
-		subsystemid 0x1558 0x0353 inherit
-
-		device ref xhci on
-			register "usb2_ports" = "{
-				/* Port reset messaging cannot be used,
-				 * so do not use USB2_PORT_TYPE_C for these */
-				[0] = USB2_PORT_MID(OC_SKIP), /* J_TYPEC1 */
-				[1] = USB2_PORT_MID(OC_SKIP), /* J_TYPEC2 */
-				[2] = USB2_PORT_MID(OC_SKIP), /* J_USB2 */
-				[3] = USB2_PORT_MID(OC_SKIP), /* J_USB1 (Audio board) */
-				[6] = USB2_PORT_MID(OC_SKIP), /* Fingerprint */
-				[7] = USB2_PORT_MID(OC_SKIP), /* Camera */
-				[13] = USB2_PORT_MID(OC_SKIP), /* Bluetooth */
-			}"
-
-			register "usb3_ports" = "{
-				[0] = USB3_PORT_DEFAULT(OC_SKIP), /* Type-C */
-				[1] = USB3_PORT_DEFAULT(OC_SKIP), /* Type-C */
-				[2] = USB3_PORT_DEFAULT(OC_SKIP), /* J_USB2 */
-				[3] = USB3_PORT_DEFAULT(OC_SKIP), /* J_USB1 (Audio board) */
-			}"
-		end
-
-		device ref i2c0 on
-			# Touchpad I2C bus
-			register "serial_io_i2c_mode[PchSerialIoIndexI2C0]" = "PchSerialIoPci"
-			chip drivers/i2c/hid
-				register "generic.hid" = ""ELAN0412""
-				register "generic.desc" = ""ELAN Touchpad""
-				register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPP_E7)"
-				register "generic.detect" = "1"
-				register "hid_desc_reg_offset" = "0x01"
-				device i2c 15 on end
-			end
-			chip drivers/i2c/hid
-				register "generic.hid" = ""FTCS1000""
-				register "generic.desc" = ""FocalTech Touchpad""
-				register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPP_E7)"
-				register "generic.detect" = "1"
-				register "hid_desc_reg_offset" = "0x01"
-				device i2c 38 on end
-			end
-		end
-
-		device ref pcie5_0 on
-			# DGPU
-			register "cpu_pcie_rp[CPU_RP(2)]" = "{
-				.clk_src = 14,
-				.clk_req = 14,
-				.flags = PCIE_RP_LTR | PCIE_RP_AER,
-			}"
-		end
-
-		device ref pcie_rp3 on
-			# GLAN
-			register "pch_pcie_rp[PCH_RP(3)]" = "{
-				.clk_src = 13,
-				.clk_req = 13,
-				.flags = PCIE_RP_LTR | PCIE_RP_AER,
-			}"
-			device pci 00.0 on end # Realtek RTL8111H
-		end
-		device ref pcie_rp8 on
-                        # WLAN
-			register "pch_pcie_rp[PCH_RP(8)]" = "{
-				.clk_src = 11,
-				.clk_req = 11,
-				.flags = PCIE_RP_LTR | PCIE_RP_AER,
-			}"
-		end
-		device ref pcie_rp13 on
-			# J_SSD1
-			register "pch_pcie_rp[PCH_RP(13)]" = "{
-				.clk_src = 10,
-				.clk_req = 10,
-				.flags = PCIE_RP_LTR | PCIE_RP_AER,
-			}"
-		end
-		device ref pcie_rp21 on
-			# J_SSD2
-			register "pch_pcie_rp[PCH_RP(21)]" = "{
-				.clk_src = 5,
-				.clk_req = 5,
-				.flags = PCIE_RP_LTR | PCIE_RP_AER,
-			}"
-		end
-		device ref pcie_rp25 on
-			# J_SSD3
-			register "pch_pcie_rp[PCH_RP(25)]" = "{
-				.clk_src = 15,
-				.clk_req = 15,
-				.flags = PCIE_RP_LTR | PCIE_RP_AER,
-			}"
-		end
-	end
-end

src/mainboard/system76/rpl/variants/addw4/romstage.c

@@ -1,43 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <drivers/gfx/nvidia/gpu.h>
-#include <soc/meminit.h>
-#include <soc/romstage.h>
-#include <variant/gpio.h>
-
-void mainboard_memory_init_params(FSPM_UPD *mupd)
-{
-	const struct mb_cfg board_cfg = {
-		.type = MEM_TYPE_DDR5,
-		.ect = true,
-		.LpDdrDqDqsReTraining = 1,
-		.ddr_config = {
-			.dq_pins_interleaved = true,
-		},
-	};
-	const struct mem_spd spd_info = {
-		.topo = MEM_TOPO_DIMM_MODULE,
-		.smbus = {
-			[0] = { .addr_dimm[0] = 0x50, },
-			[1] = { .addr_dimm[0] = 0x52, },
-		},
-	};
-	const bool half_populated = false;
-
-	const struct nvidia_gpu_config config = {
-		.power_gpio = DGPU_PWR_EN,
-		.reset_gpio = DGPU_RST_N,
-		.enable = true,
-	};
-
-	// Enable dGPU power
-	nvidia_set_power(&config);
-
-	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 4;
-
-	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
-	mupd->FspmConfig.GpioOverride = 0;
-
-	memcfg_init(mupd, &board_cfg, &spd_info, half_populated);
-}

src/mainboard/system76/rpl/variants/bonw15/romstage.c

@@ -33,8 +33,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;

src/mainboard/system76/rpl/variants/gaze18/overridetree.cb

@@ -63,7 +63,6 @@ chip soc/intel/alderlake
 				.clk_src = 1,
 				.clk_req = 1,
 				.flags = PCIE_RP_LTR | PCIE_RP_AER,
-				.pcie_rp_detect_timeout_ms = 50,
 			}"
 		end
 		device ref pcie_rp9 on

src/mainboard/system76/rpl/variants/gaze18/romstage.c

@@ -30,8 +30,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;

src/mainboard/system76/rpl/variants/lemp12/overridetree.cb

@@ -79,7 +79,6 @@ chip soc/intel/alderlake
 				.clk_src = 1,
 				.clk_req = 1,
 				.flags = PCIE_RP_LTR,
-				.pcie_rp_detect_timeout_ms = 50,
 			}"
 		end
 	end

src/mainboard/system76/rpl/variants/oryp11/romstage.c

@@ -30,8 +30,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;

src/mainboard/system76/rpl/variants/serw13/romstage.c

@@ -32,8 +32,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	mupd->FspmConfig.DmiMaxLinkSpeed = 4;
 	mupd->FspmConfig.GpioOverride = 0;

src/mainboard/system76/tgl-h/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/tgl-h/acpi/mainboard.asl

@@ -9,6 +9,7 @@
 Scope (\_SB) {
 	#include "sleep.asl"
 	Scope (PCI0) {
+		#include "backlight.asl"
 		Scope (PEG1) {
 			#include <drivers/gfx/nvidia/acpi/tigerlake.asl>
 		}

src/mainboard/system76/tgl-h/dsdt.asl

@@ -20,7 +20,6 @@ DefinitionBlock(
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/tigerlake/acpi/southbridge.asl>
 		#include <soc/intel/tigerlake/acpi/tcss.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/tgl-h/romstage.c

@@ -34,8 +34,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	// Enable dGPU power
 	nvidia_set_power(&config);
 
-	// Set primary display to internal graphics
+	// Set primary display to hybrid graphics
-	mupd->FspmConfig.PrimaryDisplay = 0;
+	mupd->FspmConfig.PrimaryDisplay = 4;
 
 	variant_memory_init_params(mupd);
 

src/mainboard/system76/tgl-u/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/tgl-u/acpi/mainboard.asl

@@ -11,6 +11,7 @@
 Scope (\_SB) {
 	#include "sleep.asl"
 	Scope (PCI0) {
+		#include "backlight.asl"
 #if CONFIG(BOARD_SYSTEM76_GALP5)
 		Scope (RP01) { // Remapped from RP05
 			#include <drivers/gfx/nvidia/acpi/tigerlake.asl>

src/mainboard/system76/tgl-u/dsdt.asl

@@ -20,7 +20,6 @@ DefinitionBlock(
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/tigerlake/acpi/southbridge.asl>
 		#include <soc/intel/tigerlake/acpi/tcss.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/mainboard/system76/tgl-u/variants/galp5/romstage.c

@@ -29,6 +29,7 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
 	nvidia_set_power(&config);
 
 	// Set primary display to internal graphics
+	// NOTE: Use iGFX as some units don't have a dGPU for hybrid graphics
 	mupd->FspmConfig.PrimaryDisplay = 0;
 
 	memcfg_init(mupd, &board_cfg, &spd_info, half_populated);

src/mainboard/system76/whl-u/acpi/backlight.asl

@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <drivers/intel/gma/acpi/gma.asl>
+
+Scope (GFX0)
+{
+	Name (BRIG, Package (22) {
+		40, /* default AC */
+		40, /* default Battery */
+		5,
+		10,
+		15,
+		20,
+		25,
+		30,
+		35,
+		40,
+		45,
+		50,
+		55,
+		60,
+		65,
+		70,
+		75,
+		80,
+		85,
+		90,
+		95,
+		100
+	})
+}

src/mainboard/system76/whl-u/acpi/mainboard.asl

@@ -6,6 +6,9 @@
 
 Scope (\_SB) {
 	#include "sleep.asl"
+	Scope (PCI0) {
+		#include "backlight.asl"
+	}
 }
 
 Scope (\_GPE) {

src/mainboard/system76/whl-u/dsdt.asl

@@ -19,7 +19,6 @@ DefinitionBlock(
 	{
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/cannonlake/acpi/southbridge.asl>
-		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 	}
 
 	#include <southbridge/intel/common/acpi/sleepstates.asl>

src/soc/intel/alderlake/Kconfig

@@ -560,9 +560,4 @@ config HSPHY_FW_MAX_SIZE
 config HAVE_BMP_LOGO_COMPRESS_LZMA
 	default n
 
-config SOC_INTEL_COMMON_BLOCK_ACPI_SLP_S0_FREQ_HZ
-	default 0x2005
-	help
-	  slp_s0_residency granularity in 122us ticks (i.e. ~8.2KHz).
-
 endif

src/soc/intel/alderlake/fsp_params.c

@@ -680,10 +680,6 @@ static void fill_fsps_tcss_params(FSP_S_CONFIG *s_cfg,
 		if (is_dev_enabled(tcss_port_arr[i]))
 			s_cfg->UsbTcPortEn |= BIT(i);
 	}
-
-#if !CONFIG(SOC_INTEL_ALDERLAKE_PCH_M)
-	s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER);
-#endif
 }
 
 static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg,

src/soc/intel/tigerlake/acpi/tcss.asl

@@ -363,6 +363,12 @@ Scope (\_SB.PCI0)
 		Offset(0x10),
 		RBAR, 64        /* RegBar, offset 0x7110 in MCHBAR */
 	}
+	Field (MBAR, DWordAcc, NoLock, Preserve)
+	{
+		Offset(0x304),  /* PRIMDN_MASK1_0_0_0_MCHBAR_IMPH, offset 0x7404 */
+		,     31,
+		TCD3, 1         /* [31:31] TCSS IN D3 bit */
+	}
 
 	/*
 	 * Operation region defined to access the pCode mailbox interface. Get the MCHBAR
@@ -398,6 +404,101 @@ Scope (\_SB.PCI0)
 		Return (0)
 	}
 
+	/*
+	 * Method to send pCode MailBox command TCSS_DEVEN_MAILBOX_SUBCMD_GET_STATUS
+	 *
+	 * Result will be updated in DATA[1:0]
+	 * DATA[0:0] TCSS_DEVEN_CURRENT_STATE:
+	 *	0 - TCSS Deven in normal state.
+	 *	1 - TCSS Deven is cleared by BIOS Mailbox request.
+	 * DATA[1:1] TCSS_DEVEN_REQUEST_STATUS:
+	 *	0 - IDLE. TCSS DEVEN has reached its final requested state.
+	 *	1 - In Progress. TCSS DEVEN is currently in progress of switching state
+	 *	    according to given request (bit 0 reflects source state).
+	 *
+	 * Return 0x00 - TCSS Deven in normal state
+	 *	  0x01 - TCSS Deven is cleared by BIOS Mailbox request
+	 *	  0x1x - TCSS Deven is in progress of switching state according to given request
+	 *	  0xFE - Command timeout
+	 *	  0xFF - Command corrupt
+	 */
+	Method (DSGS, 0)
+	{
+		If ((PMBY () == 0)) {
+			PMBC = MAILBOX_BIOS_CMD_TCSS_DEVEN_INTERFACE
+			PSCM = TCSS_DEVEN_MAILBOX_SUBCMD_GET_STATUS
+			PMBR = 1
+			If (PMBY () == 0) {
+				Local0 = PMBD
+				Local1 = PMBC
+				Stall (10)
+				If ((Local0 != PMBD) || (Local1 != PMBC)) {
+					Printf("pCode MailBox is corrupt.")
+					Return (0xFF)
+				}
+				Return (Local0)
+			} Else {
+				Printf("pCode MailBox is not ready.")
+				Return (0xFE)
+			}
+		} Else {
+			Printf("pCode MailBox is not ready.")
+			Return (0xFE)
+		}
+	}
+
+	/*
+	 * Method to send pCode MailBox command TCSS_DEVEN_MAILBOX_SUBCMD_TCSS_CHANGE_REQ
+	 *
+	 * Arg0 : 0 - Restore to previously saved value of TCSS DEVEN
+	 *	  1 - Save current TCSS DEVEN value and clear it
+	 *
+	 * Return 0x00 - MAILBOX_BIOS_CMD_CLEAR_TCSS_DEVEN command completed
+	 *	  0xFD - Input argument is invalid
+	 *	  0xFE - Command timeout
+	 *	  0xFF - Command corrupt
+	 */
+	Method (DSCR, 1)
+	{
+		If (Arg0 > 1) {
+			Printf("pCode MailBox is corrupt.")
+			Return (0xFD)
+		}
+		If ((PMBY () == 0)) {
+			PMBC = MAILBOX_BIOS_CMD_TCSS_DEVEN_INTERFACE
+			PSCM = TCSS_DEVEN_MAILBOX_SUBCMD_TCSS_CHANGE_REQ
+			PMBD = Arg0
+			PMBR = 1
+			If ((PMBY () == 0)) {
+				Local0 = PMBD
+				Local1 = PMBC
+				Stall (10)
+				If ((Local0 != PMBD) || (Local1 != PMBC)) {
+					Printf("pCode MailBox is corrupt.")
+					Return (0xFF)
+				}
+				/* Poll TCSS_DEVEN_REQUEST_STATUS, timeout value is 10ms. */
+				Local0 = 0
+				While ((DSGS () & 0x10) && (Local0 < 100)) {
+					Stall (100)
+					Local0++
+				}
+				If (Local0 == 100) {
+					Printf("pCode MailBox is not ready.")
+					Return (0xFE)
+				} Else {
+					Return (0x00)
+				}
+			} Else {
+				Printf("pCode MailBox is not ready.")
+				Return (0xFE)
+			}
+		} Else {
+			Printf("pCode MailBox is not ready.")
+			Return (0xFE)
+		}
+	}
+
 	/*
 	 * IOM REG BAR Base address is in offset 0x7110 in MCHBAR.
 	 */
@@ -466,10 +567,6 @@ Scope (\_SB.PCI0)
 				/* DMA0 is not in D3Cold now. */
 				\_SB.PCI0.TDM0.D3CE()  /* Enable DMA RTD3 */
 
-				If (\_SB.PCI0.TDM0.IF30 != 1) {
-					Return
-				}
-
 				Printf("Push TBT RPs to D3Cold together")
 				If (\_SB.PCI0.TRP0.VDID != 0xFFFFFFFF) {
 					/* Put RP0 to D3 cold. */
@@ -525,10 +622,6 @@ Scope (\_SB.PCI0)
 				/* DMA1 is not in D3Cold now */
 				\_SB.PCI0.TDM1.D3CE()  /* Enable DMA RTD3. */
 
-				If (\_SB.PCI0.TDM0.IF30 != 1) {
-					Return
-				}
-
 				Printf("Push TBT RPs to D3Cold together")
 				If (\_SB.PCI0.TRP2.VDID != 0xFFFFFFFF) {
 					/* Put RP2 to D3 cold. */
@@ -606,7 +699,26 @@ Scope (\_SB.PCI0)
 			}
 			Else
 			{
-				Printf("TCSS D3 exit.");
+				/*
+				 * Program IOP MCTP Drop (TCSS_IN_D3) after D3 cold exit and
+				 * acknowledgement by IOM.
+				 */
+				TCD3 = 0
+				/*
+				 * If the TCSS Deven is cleared by BIOS Mailbox request, then
+				 * restore to previously saved value of TCSS DEVNE.
+				 */
+				Local0 = 0
+				While (\_SB.PCI0.TXHC.VDID == 0xFFFFFFFF) {
+					If (DSGS () == 1) {
+						DSCR (0)
+					}
+					Local0++
+					If (Local0 == 5) {
+						Printf("pCode mailbox command failed.")
+						Break
+					}
+				}
 			}
 		}
 		Else {
@@ -623,6 +735,27 @@ Scope (\_SB.PCI0)
 			Return
 		}
 
+		/*
+		 * If the TCSS Deven in normal state, then Save current TCSS DEVEN value and
+		 * clear it.
+		 */
+		Local0 = 0
+		While (\_SB.PCI0.TXHC.VDID != 0xFFFFFFFF) {
+			If (DSGS () == 0) {
+				DSCR (1)
+			}
+			Local0++
+			If (Local0 == 5) {
+				Printf("pCode mailbox command failed.")
+				Break
+			}
+		}
+
+		/*
+		 * Program IOM MCTP Drop (TCSS_IN_D3) in D3Cold entry before entering D3 cold.
+		 */
+		TCD3 = 1
+
 		/* Request IOM for D3 cold entry sequence. */
 		TD3C = 1
 	}

src/soc/intel/tigerlake/acpi/tcss_dma.asl

@@ -11,8 +11,7 @@ Field (DPME, AnyAcc, NoLock, Preserve)
 	, 6,
 	PMES, 1,        /* 15, PME_STATUS */
 	Offset(0xC8),   /* 0xC8, TBT NVM FW Revision */
-	,     30,
+	,     31,
-	IF30,  1,	/* ITBT FW Version Bit30 */
 	INFR,  1,       /* TBT NVM FW Ready */
 	Offset(0xEC),   /* 0xEC, TBT TO PCIE Register */
 	TB2P, 32,       /* TBT to PCIe */