320edbe2ba
The virtualized developer switch was invented five years ago and has been used on every vboot system ever since. We shouldn't need to specify it again and again for every new board. This patch flips the Kconfig logic around and replaces CONFIG_VIRTUAL_DEV_SWITCH with CONFIG_PHYSICAL_DEV_SWITCH, so that only a few ancient boards need to set it and it fits better with CONFIG_PHYSICAL_REC_SWITCH. (Also set the latter for Lumpy which seems to have been omitted incorrectly, and hide it from menuconfig since it's a hardware parameter that shouldn't be configurable.) Since almost all our developer switches are virtual, it doesn't make sense for every board to pass a non-existent or non-functional developer mode switch in the coreboot tables, so let's get rid of that. It's also dangerously confusing for many boards to define a get_developer_mode() function that reads an actual pin (often from a debug header) which will not be honored by coreboot because CONFIG_PHYSICAL_DEV_SWITCH isn't set. Therefore, this patch removes all those non-functional instances of that function. In the future, either the board has a physical dev switch and must define it, or it doesn't and must not. In a similar sense (and since I'm touching so many board configs anyway), it's annoying that we have to keep selecting EC_SOFTWARE_SYNC. Instead, it should just be assumed by default whenever a Chrome EC is present in the system. This way, it can also still be overridden by menuconfig. CQ-DEPEND=CL:459701 Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/18980 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
75 lines
1.5 KiB
Plaintext
75 lines
1.5 KiB
Plaintext
##
|
|
## This file is part of the coreboot project.
|
|
##
|
|
## Copyright 2014 Rockchip Inc.
|
|
##
|
|
## This program is free software; you can redistribute it and/or modify
|
|
## it under the terms of the GNU General Public License as published by
|
|
## the Free Software Foundation; version 2 of the License.
|
|
##
|
|
## This program is distributed in the hope that it will be useful,
|
|
## but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
## GNU General Public License for more details.
|
|
##
|
|
|
|
if BOARD_GOOGLE_VEYRON_RIALTO
|
|
|
|
config BOARD_SPECIFIC_OPTIONS # dummy
|
|
def_bool y
|
|
select BOARD_ID_AUTO
|
|
select BOARD_ROMSIZE_KB_4096
|
|
select COMMON_CBFS_SPI_WRAPPER
|
|
select HAVE_HARD_RESET
|
|
select MAINBOARD_HAS_NATIVE_VGA_INIT
|
|
select MAINBOARD_DO_NATIVE_VGA_INIT
|
|
select MAINBOARD_HAS_CHROMEOS
|
|
select RAM_CODE_SUPPORT
|
|
select SOC_ROCKCHIP_RK3288
|
|
select SPI_FLASH
|
|
select SPI_FLASH_GIGADEVICE
|
|
select SPI_FLASH_WINBOND
|
|
|
|
config CHROMEOS
|
|
select PHYSICAL_REC_SWITCH
|
|
select VBOOT_VBNV_FLASH
|
|
|
|
config MAINBOARD_DIR
|
|
string
|
|
default google/veyron_rialto
|
|
|
|
config MAINBOARD_PART_NUMBER
|
|
string
|
|
default "Veyron_Rialto"
|
|
|
|
config MAINBOARD_VENDOR
|
|
string
|
|
default "Google"
|
|
|
|
config BOOT_DEVICE_SPI_FLASH_BUS
|
|
int
|
|
default 2
|
|
|
|
config DRIVER_TPM_I2C_BUS
|
|
hex
|
|
default 0x1
|
|
|
|
config DRIVER_TPM_I2C_ADDR
|
|
hex
|
|
default 0x20
|
|
|
|
config CONSOLE_SERIAL_UART_ADDRESS
|
|
hex
|
|
depends on DRIVERS_UART
|
|
default 0xFF690000
|
|
|
|
config PMIC_BUS
|
|
int
|
|
default 0
|
|
|
|
config GBB_HWID
|
|
string
|
|
depends on CHROMEOS
|
|
default "RIALTO TEST A-A 2322"
|
|
endif # BOARD_GOOGLE_VEYRON_RIALTO
|