UefiPayloadPkg: Add SmmStoreInfoGuid

Add a new InfoHob that contains the SmmStore information passed from
coreboot tables when the SMMSTOREV2 feature is enabled.

This will be used to implement the FVB in top of the MM installed by
coreboot.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Change-Id: Ia3f7eef27d4758768c1a6736afe1cb77ee6a2f8f
This commit is contained in:
Patrick Rudolph
2022-02-25 11:58:59 +01:00
committed by Tim Crawford
parent bb19b4bc30
commit 13dd54ae32
8 changed files with 135 additions and 0 deletions

View File

@@ -0,0 +1,27 @@
/** @file
This file defines the hob structure for coreboot's SmmStore.
Copyright (c) 2022, 9elements GmbH<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
#ifndef SMMSTORE_GUID_H_
#define SMMSTORE_GUID_H_
///
/// System Table Information GUID
///
extern EFI_GUID gEfiSmmStoreInfoHobGuid;
typedef struct {
UINT64 ComBuffer;
UINT32 ComBufferSize;
UINT32 NumBlocks;
UINT32 BlockSize;
UINT64 MmioAddress;
UINT8 ApmCmd;
UINT8 Reserved0[3];
} SMMSTORE_INFO;
#endif // SMMSTORE_GUID_H_

View File

@@ -0,0 +1,29 @@
/** @file
This library will parse the coreboot table in memory and extract those required
information.
Copyright (c) 2021, Star Labs Systems. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
#ifndef SMM_STORE_PARSE_LIB_H_
#define SMM_STORE_PARSE_LIB_H_
#include <Guid/SmmStoreInfoGuid.h>
/**
Find the SmmStore HOB.
@param SmmStoreInfo Pointer to the SMMSTORE_INFO structure
@retval RETURN_SUCCESS Successfully find the Smm store buffer information.
@retval RETURN_NOT_FOUND Failed to find the Smm store buffer information .
**/
RETURN_STATUS
EFIAPI
ParseSmmStoreInfo (
OUT SMMSTORE_INFO *SmmStoreInfo
);
#endif // SMM_STORE_PARSE_LIB_H_

View File

@@ -14,6 +14,7 @@
#include <Library/PcdLib.h>
#include <Library/IoLib.h>
#include <Library/BlParseLib.h>
#include <Library/SmmStoreParseLib.h>
#include <IndustryStandard/Acpi.h>
#include <Coreboot.h>
@@ -604,3 +605,45 @@ ParseMiscInfo (
{
return RETURN_SUCCESS;
}
/**
Find the SmmStore HOB.
@param SmmStoreInfo Pointer to the SMMSTORE_INFO structure
@retval RETURN_SUCCESS Successfully find the Smm store buffer information.
@retval RETURN_NOT_FOUND Failed to find the Smm store buffer information .
**/
RETURN_STATUS
EFIAPI
ParseSmmStoreInfo (
OUT SMMSTORE_INFO *SmmStoreInfo
)
{
struct cb_smmstorev2 *CbSSRec;
if (SmmStoreInfo == NULL) {
return RETURN_INVALID_PARAMETER;
}
CbSSRec = FindCbTag (CB_TAG_SMMSTOREV2);
if (CbSSRec == NULL) {
return RETURN_NOT_FOUND;
}
DEBUG ((DEBUG_INFO, "Found Smm Store information\n"));
DEBUG ((DEBUG_INFO, "block size: 0x%x\n", CbSSRec->block_size));
DEBUG ((DEBUG_INFO, "number of blocks: 0x%x\n", CbSSRec->num_blocks));
DEBUG ((DEBUG_INFO, "communication buffer: 0x%x\n", CbSSRec->com_buffer));
DEBUG ((DEBUG_INFO, "communication buffer size: 0x%x\n", CbSSRec->com_buffer_size));
DEBUG ((DEBUG_INFO, "MMIO address of store: 0x%x\n", CbSSRec->mmap_addr));
SmmStoreInfo->ComBuffer = CbSSRec->com_buffer;
SmmStoreInfo->ComBufferSize = CbSSRec->com_buffer_size;
SmmStoreInfo->BlockSize = CbSSRec->block_size;
SmmStoreInfo->NumBlocks = CbSSRec->num_blocks;
SmmStoreInfo->MmioAddress = CbSSRec->mmap_addr;
SmmStoreInfo->ApmCmd = CbSSRec->apm_cmd;
return RETURN_SUCCESS;
}

View File

@@ -14,6 +14,7 @@
#include <Library/IoLib.h>
#include <Library/HobLib.h>
#include <Library/BlParseLib.h>
#include <Library/SmmStoreParseLib.h>
#include <IndustryStandard/Acpi.h>
#include <UniversalPayload/PciRootBridges.h>
@@ -289,3 +290,20 @@ ParseMiscInfo (
return Status;
}
/**
Find the SmmStore HOB.
@param SmmStoreInfo Pointer to the SMMSTORE_INFO structure
@retval RETURN_SUCCESS Successfully find the Smm store buffer information.
@retval RETURN_NOT_FOUND Failed to find the Smm store buffer information .
**/
RETURN_STATUS
EFIAPI
ParseSmmStoreInfo (
OUT SMMSTORE_INFO *SmmStoreInfo
)
{
return RETURN_NOT_FOUND;
}

View File

@@ -259,6 +259,8 @@ BuildHobFromBl (
{
EFI_STATUS Status;
ACPI_BOARD_INFO *AcpiBoardInfo;
SMMSTORE_INFO SmmStoreInfo;
SMMSTORE_INFO *NewSmmStoreInfo;
EFI_PEI_GRAPHICS_INFO_HOB GfxInfo;
EFI_PEI_GRAPHICS_INFO_HOB *NewGfxInfo;
EFI_PEI_GRAPHICS_DEVICE_INFO_HOB GfxDeviceInfo;
@@ -305,6 +307,17 @@ BuildHobFromBl (
DEBUG ((DEBUG_INFO, "Created graphics device info hob\n"));
}
//
// Create guid hob for SmmStore
//
Status = ParseSmmStoreInfo (&SmmStoreInfo);
if (!EFI_ERROR (Status)) {
NewSmmStoreInfo = BuildGuidHob (&gEfiSmmStoreInfoHobGuid, sizeof (SmmStoreInfo));
ASSERT (NewSmmStoreInfo != NULL);
CopyMem (NewSmmStoreInfo, &SmmStoreInfo, sizeof (SmmStoreInfo));
DEBUG ((DEBUG_INFO, "Created SmmStore info hob\n"));
}
//
// Creat SmBios table Hob
//

View File

@@ -22,6 +22,7 @@
#include <Library/IoLib.h>
#include <Library/PeCoffLib.h>
#include <Library/BlParseLib.h>
#include <Library/SmmStoreParseLib.h>
#include <Library/PlatformSupportLib.h>
#include <Library/CpuLib.h>
#include <Library/UefiCpuLib.h>
@@ -37,6 +38,7 @@
#include <UniversalPayload/ExtraData.h>
#include <UniversalPayload/SerialPortInfo.h>
#include <Guid/PcdDataBaseSignatureGuid.h>
#include <Guid/SmmStoreInfoGuid.h>
#define LEGACY_8259_MASK_REGISTER_MASTER 0x21
#define LEGACY_8259_MASK_REGISTER_SLAVE 0xA1

View File

@@ -66,6 +66,7 @@
gUniversalPayloadSmbiosTableGuid
gUniversalPayloadAcpiTableGuid
gUniversalPayloadSerialPortInfoGuid
gEfiSmmStoreInfoHobGuid
[FeaturePcd.IA32]
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode ## CONSUMES

View File

@@ -43,6 +43,8 @@
gSmmRegisterInfoGuid = { 0xaa9bd7a7, 0xcafb, 0x4499, { 0xa4, 0xa9, 0xb, 0x34, 0x6b, 0x40, 0xa6, 0x22 } }
gS3CommunicationGuid = { 0x88e31ba1, 0x1856, 0x4b8b, { 0xbb, 0xdf, 0xf8, 0x16, 0xdd, 0x94, 0xa, 0xef } }
gEfiSmmStoreInfoHobGuid = { 0xf585ca19, 0x881b, 0x44fb, { 0x3f, 0x3d, 0x81, 0x89, 0x7c, 0x57, 0xbb, 0x01 } }
[Ppis]
gEfiPayLoadHobBasePpiGuid = { 0xdbe23aa1, 0xa342, 0x4b97, {0x85, 0xb6, 0xb2, 0x26, 0xf1, 0x61, 0x73, 0x89} }