NetworkPkg/HttpDxe: Fix build warning error if CHAR8 is unsigned.
This patch is to fix the compiler warning error: C4245. The issue will happen
if the below build option is enabled:
*_*_*_CC_FLAGS = -J.
That's because the value of ('A' - 'a') is a negative value, which will
be converted to an unsigned type if CHAR8 is treated as unsigned:
Src -= ('A' - 'a');
The above issue is also recorded at:
https://bugzilla.tianocore.org/show_bug.cgi?id=815.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
(cherry picked from commit 1e4725e569
)
This commit is contained in:
@@ -67,11 +67,11 @@ AsciiStrCaseStr (
|
||||
Dst = *SearchStringTmp;
|
||||
|
||||
if ((Src >= 'A') && (Src <= 'Z')) {
|
||||
Src -= ('A' - 'a');
|
||||
Src += ('a' - 'A');
|
||||
}
|
||||
|
||||
if ((Dst >= 'A') && (Dst <= 'Z')) {
|
||||
Dst -= ('A' - 'a');
|
||||
Dst += ('a' - 'A');
|
||||
}
|
||||
|
||||
if (Src != Dst) {
|
||||
|
Reference in New Issue
Block a user