sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdeModulePkg/UsbMass: Fix USB key write failure

Browse Source 
Commit e59db6a732
* MdeModulePkg/UsbMass: Merge UsbBoot(Read|Write)Blocks(16)
introduces a bug that causes writing to USB key always fails.

When that patch is verified, only reading was verified.

The root cause is when the writing operation is performed,
the data direction EfiUsbDataIn is wrongly used. Instead, it
should be EfiUsbDataOut.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
Ruiyu Ni
2018-10-23 10:26:01 +08:00
parent 90c64aada8
commit a58a421c36
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
View File

@ -861,7 +861,7 @@ UsbBootReadWriteBlocks (
UsbMass,
&Cmd,
(UINT8) sizeof (USB_BOOT_READ_WRITE_10_CMD),
EfiUsbDataIn,
Write ? EfiUsbDataOut : EfiUsbDataIn,
Buffer,
ByteSize,
Timeout
@ -941,7 +941,7 @@ UsbBootReadWriteBlocks16 (
UsbMass,
Cmd,
(UINT8) sizeof (Cmd),
EfiUsbDataIn,
Write ? EfiUsbDataOut : EfiUsbDataIn,
Buffer,
ByteSize,
Timeout