yi1 li
1a49e2aa3c
CryptoPkg: Add instrinsics to support building ECC on IA32 windows
...
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
This dependency is needed to build openssl lib with ECC ciphers
under IA32 Windows and adds implementation for _allmul and _allshr
instrinsics.
It is taken from Project Mu:
microsoft/mu_basecore@b55b341
Cc: Jiewen Yao <jiewen.yao@intel.com >
Cc: Jian J Wang <jian.j.wang@intel.com >
Signed-off-by: yi1 li <yi1.li@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
2022-04-14 03:16:59 +00:00
Michael D Kinney
8a5727c7a8
Maintainers.txt: Add Michael Kubacki as UnitTestFrameworkPkg maintainer
...
Cc: Michael Kubacki <mikuback@linux.microsoft.com >
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com >
2022-04-13 23:49:08 +00:00
Bob Feng
c411566fad
pip-requirements.txt: Update basetools version to 0.1.17
...
Synced the basetools patch from edk2 repo to
edk2-basetools repo. Update the basetools pip module version
to the latest.
Signed-off-by: Bob Feng <bob.c.feng@intel.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
2022-04-13 00:02:47 +00:00
Gerd Hoffmann
f5508a91e3
CryptoPkg/UnitTest: fix DH testcase
...
openssl 3.0 wants at least 512 bytes, otherwise it throws an error:
error:0280007E:Diffie-Hellman routines::modulus too small
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Gerd Hoffmann
fab6285a73
CryptoPkg/CrtLibSupport: fix strcpy
...
strcpy() returns a pointer to the destination string, AsciiStrCpyS()
does not. So a simple #define does not work. Create a function
instead.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Gerd Hoffmann
03951e5645
CryptoPkg/CrtLibSupport: add off_t
...
Add typedef for off_t.
Will be needed by openssl 3.0.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Gerd Hoffmann
fd5f347c84
CryptoPkg/CrtLibSupport: add MODULESDIR
...
Add dummy MODULESDIR #define
Will be needed by openssl 3.0.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Gerd Hoffmann
2759e42fbc
CryptoPkg/CrtLibSupport: add UINT_MAX
...
Add define for UINT_MAX.
Will be needed by openssl 3.0.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Gerd Hoffmann
58771f4b2d
CryptoPkg/CrtLibSupport: add INT_MIN
...
Add #define for INT_MIN.
Will be needed by openssl 3.0.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Gerd Hoffmann
3b4b49cf00
CryptoPkg/CrtLibSupport: add strstr()
...
Add #define for strstr().
Will be needed by openssl 3.0.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Gerd Hoffmann
4352d115c4
CryptoPkg/CrtLibSupport: add fcntl.h
...
Add fcntl.h header file.
Will be needed by openssl 3.0.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2022-04-12 14:39:01 +00:00
Feng, Bob C
5576b17363
BaseTools: Fix DevicePath tool build failure issue
...
Fix the DevicePath tool build failure that was introduced by
the fixes: 22130dcd98
("Basetools: turn off gcc12 warning").
Failure cases are:
1. clang 13.1.6 on macOS
2. gcc5.4
Reported-by: Rebecca Cran <rebecca@bsdio.com >
Reported-by: Yuwei Chen <yuwei.chen@intel.com >
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Signed-off-by: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Yuwei Chen <yuwei.chen@intel.com >
Cc: Rebecca Cran <rebecca@bsdio.com >
Reviewed-by: Yuwei Chen <yuwei.chen@intel.com >
2022-04-12 07:01:26 +00:00
Oliver Steffen
12a50c9ce1
NetworkPkg/HttpDxe: Detect HTTP/1.0 servers
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Force connection close before the next request if
the server identifies as version 1.0.
Signed-off-by: Oliver Steffen <osteffen@redhat.com >
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com >
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com >
2022-04-11 15:12:46 +00:00
Oliver Steffen
753fd319e2
NetworkPkg/HttpDxe: Detect 'Connection: close' header
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Force connection close before the next request if
the server sends the 'Connection: close' header.
Signed-off-by: Oliver Steffen <osteffen@redhat.com >
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com >
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com >
2022-04-11 15:12:46 +00:00
Oliver Steffen
c43ff5188d
NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Add ConnectionClose flag to HTTP_PROTOCOL.
This boolean is FALSE by default. If set to TRUE, a reconfigure
of the Http instance is forced on the next request. The flag
is then reset.
Signed-off-by: Oliver Steffen <osteffen@redhat.com >
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com >
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com >
2022-04-11 15:12:46 +00:00
Oliver Steffen
3974aa539e
NetworkPkg/HttpDxe: Decofigure Tcp6 before reconfiguring
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or
HTTP_STATE_TCP_CLOSED and de-configure the Tcp6 instance before
configuring it again.
Signed-off-by: Oliver Steffen <osteffen@redhat.com >
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com >
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com >
2022-04-11 15:12:46 +00:00
Oliver Steffen
38a9afd0fb
NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or
HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before
configuring it again.
Signed-off-by: Oliver Steffen <osteffen@redhat.com >
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com >
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com >
2022-04-11 15:12:46 +00:00
Heng Luo
35a4b63247
NetworkPkg: Add PCDs for HTTP DNS RetryCount and RetryInterval
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3889
Currently the HTTP DNS Retry Interval is 2 second and no retry attempt.
If DNS response can't arrive in 2 second, the DNS request is failed,
and then HTTP boot is failed.
In order to resolve this issue, Add PCDs to support RetryCount
and RetryInterval configured in Platform.
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com >
Cc: Fu Siyuan <siyuan.fu@intel.com >
Cc: Wu Jiaxin <jiaxin.wu@intel.com >
Signed-off-by: Heng Luo <heng.luo@intel.com >
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com >
2022-04-11 15:12:46 +00:00
Guo Dong
dab96cf02e
UefiPayloadPkg: Add --quiet argument to Universal Payload build script
...
Signed-off-by: Sean Rhodes <sean@starlabs.systems >
Reviewed-by: Guo Dong <guo.dong@intel.com >
Reviewed-by: Ray Ni <ray.ni@intel.com >
2022-04-10 21:00:54 +00:00
Li, Zhihao
63e155f24d
UefiPayloadPkg: Add dependency of VariableSmm driver.
...
REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3882
UefiCpuPkg define a new Protocol with the new services
SmmWaitForAllProcessor(), which can be used by SMI handler
to optionally wait for other APs to complete SMM rendezvous in
relaxed AP mode.
VariableSmm driver need use SmmCpuRendezvousLib, So add
SmmCpuRendezvousLib dependency in UefiPayloadPkg which use
VariableSmm driver.
Cc: Guo Dong <guo.dong@intel.com >
Cc: Ray Ni <ray.ni@intel.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Sean Rhodes <sean@starlabs.systems >
Cc: Siyuan Fu <siyuan.fu@intel.com >
Signed-off-by: Zhihao Li <zhihao.li@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
2022-04-10 20:33:27 +00:00
Guo Dong
676084303d
UefiPayloadPkg: Support IA32 Build
...
The payload entry module should support to build as IA32 image
beside X64 image so that it could work with 32bit bootloaders.
This patch adds a option build parameter for arch selection.
Cc: Ray Ni <ray.ni@intel.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Sean Rhodes <sean@starlabs.systems >
Signed-off-by: Guo Dong <guo.dong@intel.com >
Reviewed-by: Sean Rhodes <sean@starlabs.systems >
2022-04-10 19:36:44 +00:00
Lean Sheng Tan
bfefdc2c49
UefiPayloadPkg: Fix PciHostBridgeLib
...
Don't assume a 64bit register always holds an address greater than 4GB.
Check the value in the register and decide which Aperature it should be
assigned to.
Fixes assertion
"ASSERT [PciHostBridgeDxe] Bridge->MemAbove4G.Base >= 0x0000000100000000ULL".
Tested with coreboot as bootloader on platforms that have PCI resource
above 4GiB and on platforms that don't have resource above 4GiB.
Cc: Guo Dong <guo.dong@intel.com >
Cc: Ray Ni <ray.ni@intel.com >
Cc: Maurice Ma <maurice.ma@intel.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Sean Rhodes <sean@starlabs.systems >
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com >
Reviewed-by Sean Rhodes <sean@starlabs.systems >
Reviewed-by: Guo Dong <guo.dong@intel.com >
2022-04-10 17:46:10 +00:00
Rebecca Cran
4f4afcd288
BaseTools: Scripts/efi_lldb.py: Add lldb EFI commands and pretty Print
...
https://bugzilla.tianocore.org/show_bug.cgi?id=3500
Use efi_debugging.py Python Classes to implement EFI gdb commands:
efi_symbols, guid, table, hob, and devicepath
You can attach to any standard gdb or kdp remote server and get EFI
symbols. No modifications of EFI are required.
Example usage:
OvmfPkg/build.sh qemu -gdb tcp::9000
lldb -o "gdb-remote localhost:9000" -o "command script import efi_lldb.py"
Note you may also have to teach lldb about QEMU:
-o "settings set plugin.process.gdb-remote.target-definition-file
x86_64_target_definition.py"
Cc: Leif Lindholm <quic_llindhol@quicinc.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Hao A Wu <hao.a.wu@intel.com >
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Yuwei Chen <yuwei.chen@intel.com >
Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
2022-04-09 05:13:56 +00:00
Rebecca Cran
0d7fec9f79
BaseTools: Scripts/efi_gdb.py: Add gdb EFI commands and pretty Print
...
https://bugzilla.tianocore.org/show_bug.cgi?id=3500
Use efi_debugging.py Python Classes to implement EFI gdb commands:
(gdb) help efi
Commands for debugging EFI. efi <cmd>
List of efi subcommands:
efi devicepath -- Display an EFI device path.
efi guid -- Display info about EFI GUID's.
efi hob -- Dump EFI HOBs. Type 'hob -h' for more info.
efi symbols -- Load Symbols for EFI. Type 'efi_symbols -h' for more info.
efi table -- Dump EFI System Tables. Type 'table -h' for more info.
This module is coded against a generic gdb remote serial stub. It should
work with QEMU, JTAG debugger, or a generic EFI gdb remote serial stub.
No modifications of EFI is required to load symbols.
Example usage:
OvmfPkg/build.sh qemu -gdb tcp::9000
gdb -ex "target remote localhost:9000" -ex "source efi_gdb.py"
Cc: Leif Lindholm <quic_llindhol@quicinc.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Hao A Wu <hao.a.wu@intel.com >
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Yuwei Chen <yuwei.chen@intel.com >
Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
2022-04-09 05:13:56 +00:00
Rebecca Cran
b8c5ba2337
BaseTools: efi_debugging.py: Add debugger agnostic dbg Python Classes
...
Add Scripts/efi_debugging.py to provide debugger agnostic debugging
utility Python classes.
Cc: Leif Lindholm <quic_llindhol@quicinc.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Hao A Wu <hao.a.wu@intel.com >
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Yuwei Chen <yuwei.chen@intel.com >
Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
2022-04-09 05:13:56 +00:00
Chen, Lin Z
94f905b3bf
MdeModulePkg/HiiDatabase: Fix Setup numeric default value incorrect issue
...
When default/manufacturing flag get removed from numeric varid, it can't
get default value from StructurePcd in 'UpdateDefaultSettingInFormPackage'
function since there is no EFI_IFR_DEFAULT_OP opcode in IFR file. Add a
chance to get numeric default value from StructurePcd in the case that
numeric minimum value will be used as default value.
Signed-off-by: Chen Lin Z <lin.z.chen@intel.com >
Signed-off-by: Dandan Bi <dandan.bi@intel.com >
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn >
2022-04-08 02:08:35 +00:00
Michael Kubacki
a298a84478
PrmPkg: Apply uncrustify changes
...
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3737
Apply uncrustify changes to .c/.h files in PrmPkg.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
f3c11224b5
PrmPkg: Changes for edk2 repo transition
...
Updates the Readme.md files to remove information that was specific
to the package in edk2-staging and adds key definitions being added
for PRM support in the ACPI Specification.
Adds PrmPkg/PrmPkg.ci.yaml to support CI.
Adds PrmPkg to .pytool/CISettings.py.
Adds PrmPkg maintainers to Maintainers.txt.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
deea4e58b0
Readme.md: Add a link to PRM Specification
...
Adds a link to the PRM Specification now that it is available on uefi.org.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
88f3d734f5
PrmPkg: Remove the concept of OS services
...
OS services are no longer supported as of the current PRM design.
1. Removes OS services from PrmSampleHardwareAccessModule
2. Removes the PrmOsServices.h file
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
050b2ba27d
PrmPkg/Samples: Remove PrmSamplePrintModule
...
This sample module is removed since it directly depends on OS
services which are no longer supported as of the current PRM
design.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
17b2d64ced
PrmPkg/Samples: Remove PrmSampleMemoryAllocationModule
...
Removes PrmSampleMemoryAllocationModule since the module depends
upon the deprecated concept of OS services.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
4a4aeaa446
PrmPkg: Replace PcdPrmPlatformGuid with EDKII_DSC_PLATFORM_GUID
...
Bugzilla request https://bugzilla.tianocore.org/show_bug.cgi?id=2969
was recently completed which causes the PLATFORM_GUID value from the
DSC file to be placed into Autogen file .c & .h files. With this
change, the PRM Platform GUID can be directly matched to the DSC
PLATFORM_GUID value.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
f8e68587e2
Readme.md: Add iASL note and QEMU sample link
...
Adds a note that the build now depends on an ASL compiler supporting
PlatformRtMechanism by default. The minimum iASL version supported
is noted in addition to an alternative to remove the code that
requires the new OperationRegion.
Also, a link is provided to an example of how to integrate the
package into a platform using QEMU/OvmfPkg as the sample platform
and firmware.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Liu Yun Y
a9302b89a9
PrmPkg: Update PRM OpRegion
...
1. Enable new PRM OpRegion structure
2. Add PRM Handler Update Lock/Unlock support
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Liu Yun <yun.y.liu@intel.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
c040831cf9
PrmPkg: Add PlatformGuid
...
Adds a "platform GUID" field to the PRM ACPI table. This field
is used by a platform to uniquely identify itself such that it
can be targeted by runtime PRM module updates for that platform.
Platforms using PRM are currently required to set a unique value
for gPrmPkgTokenSpaceGuid.PcdPrmPlatformGuid in their platform
DSC.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
68ee42c991
PrmPkg/DxePrmModuleDiscoveryLib: Add initial host-based unit tests
...
Adds host-based unit tests for DxePrmModuleDiscoveryLib. This is
an initial set of support, more tests should be added in the
future.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
82d15dc6c1
PrmPkg/Library/DxePrmContextBufferLib: Add host-based unit tests
...
Adds host-based unit tests for DxePrmContextBufferLib. This tests
each function in DxePrmContextBufferLib.
Any changes to DxePrmContextBufferLib moving forward must pass the unit
tests. The unit tests should be updated as needed if the library API
changes.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
3599f5479d
PrmPkg/Test/UnitTest/Library: Add initial UEFI Boot Services test lib
...
Adds a host-based specific implementation of UefiBootServicesTableLib.
This library implements relatively simple versions of the functionality
in the actual boot services implementation and does not depend on
dynamic linking to the boot services table.
Most unit tests can install the dependencies their code under test
depends on prior to invocation and uninstall those dependencies after
the test to test code that directly depends on boot services.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
2e55b0cd9e
PrmPkg/Test/PrmPkgHostTest.dsc: Add initial file
...
Adds a new DSC file that will be used to build host-based unit tests
in PrmPkg.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
e10c776487
PrmPkg: Enforce stricter types
...
Makes the following changes to enforce stricter types:
1. PrmPkg/PrmConfigDxe
The function PrmConfigEndOfDxeNotification () is used as a notify
function (of type EFI_EVENT_NOTIFY), however it has a return type
of EFI_STATUS whereas the return type should actually be VOID.
2. PrmPkg/PrmLoaderDxe
Updates the following types to be more accurate than were allowed
in the VS compiler:
* 3rd actual argument given to GetModuleContextBuffers () is
explicitly marked as CONST PRM_MODULE_CONTEXT_BUFFERS **
* 3rd actual argument given to GetContextBuffer () is
explicitly marked as CONST PRM_CONTEXT_BUFFER **
* PrmLoaderEndOfDxeNotification () return type is changed to VOID
to align with the EFI_EVENT_NOTIFY type
3. PrmPkg/Application/PrmInfo
Updates the following types to be more accurate than were allowed
in the VS compiler:
* SHELL_STATUS in ParseParameterList () is now EFI_STATUS
* 3rd actual argument given to GetModuleContextBuffers () is
explicitly marked as CONST PRM_MODULE_CONTEXT_BUFFERS **
* 3rd actual argument given to GetContextBuffer () is
explicitly marked as CONST PRM_CONTEXT_BUFFER **
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
4348c72ad0
PrmPkg/Application/PrmInfo: Add initial application
...
Adds a new UEFI application called "PrmInfo" that allows a user
to display and test Platform Runtime Mechanism (PRM) modules.
Execute the application help command for detailed usage
instructions and examples of how to use the application:
"PrmInfo -?"
This application is intended to be helpful during PRM enabling
by allowing the user to:
1. Confirm that their firmware port of the PRM infrastructure
implemented in this package is functioning correctly.
2. Quickly get information about what PRM modules and handlers
are present on a given system.
3. Quickly test PRM handlers without booting to a fully featured
operating system.
4. Develop and exercise PRM handlers prior to the availability of
an operating system that is PRM aware.
Adds a brief section to Readme.md about the PrmInfo UEFI application
with a link to allow the reader to find more information about the
application if interested.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
6b7dde7cdd
PrmPkg: Refactor some PrmLoaderDxe functionality into libraries
...
This change breaks out two sets of responsibilities in
PrmLoaderDxe into libraries:
* PE/COFF functions -> PrmPeCoffLib
* PRM module discovery functions -> PrmModuleDiscoveryLib
This is core infrastructure code for PRM functionality that needs
to be directly reused and tested in other places. At this time,
the primary motivating factor is to use this code in two other
locations:
1.) Link the functionality into unit testing modules
2.) Link the functionality into a PRM UEFI application
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
d10b8dc5d8
PrmPkg/Samples/Readme.md: Add initial file
...
Adds a Readme.md file for the Samples to help a user get started
building and using the PRM sample modules.
Includes a reference to the Samples/Readme.md file in the top-level
file to help make the reader aware the file exists.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
fec018624c
PrmPkg/HardwareAccessModuleConfigLib: Add initial library
...
Adds a PRM module configuration library for PrmSampleHardwareAccessModule
that demonstrates marking a runtime MMIO range. In the case of this
sample module, the range used is for HPET.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
7217263514
PrmPkg/SampleAcpiParameterBufferModule: Add initial module
...
Adds a new PRM module called SampleAcpiParameterBufferModule that
demonstrates how a PRM module can use an ACPI parameter buffer with
a PRM handler.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
4c8486fd72
PrmPkg/PrmSampleHardwareAccessModule: Add non-print PRM handlers
...
For each PRM handler that is currently present, a corresponding PRM
handler is added that does not print. This allows a caller to execute
a sample hardware access PRM handler without requiring that caller to
provide a debug print service.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
c1a7a50f67
PrmPkg/PrmSampleContextBufferModule: Remove OS debug print requirement
...
Removes the expectation that the parameter buffer contain an OS
debug print service at the beginning of the buffer. All supporting
code related to printing is also removed.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
be2c927d7c
PrmPkg/PrmLoaderDxe: Add ACPI parameter buffer support
...
Adds support to PrmLoaderDxe to move the ACPI parameter buffer
address for a given PRM handler to the corresponding field
in the PRM handler information structure (PRMT ACPI table).
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00
Michael Kubacki
0b469caff6
PrmPkg/PrmContextBuffer.h: Add ACPI parameter support structures
...
Adds a new type ACPI_PARAMETER_BUFFER_DESCRIPTOR that can be
used by PRM module configuration code to associate a PRM handler
GUID with an ACPI parameter buffer allocated by the PRM module
configuration code.
The ACPI parameter buffer descriptors for a given PRM module
are tracked in the firmware internal structure
PRM_MODULE_CONTEXT_BUFFERS produced by the module configuration
code.
Cc: Andrew Fish <afish@apple.com >
Cc: Kang Gao <kang.gao@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Benjamin You <benjamin.you@intel.com >
Cc: Liu Yun <yun.y.liu@intel.com >
Cc: Ankit Sinha <ankit.sinha@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Acked-by: Michael D Kinney <michael.d.kinney@intel.com >
Acked-by: Liming Gao <gaoliming@byosoft.com.cn >
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com >
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com >
2022-04-05 00:42:38 +00:00