REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2018 Current FSP SEC_IDT_TABLE structure is not natural aligned: typedef struct _SEC_IDT_TABLE { EFI_PEI_SERVICES *PeiService; UINT64 IdtTable[]; } SEC_IDT_TABLE; Compiler will insert DWORD padding between 2 elements and GetPeiServicesTablePointer() in early phase then always returns padding data from stack, which was not reset to 0 in SecMain. Solution is to align FSP SEC_IDT_TABLE structure to UefiCpuPkg to have UINT64 as PeiService field and reset it to 0. Test: Verified on internal platform and booting successfully with FSP API mode. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Star Zeng <star.zeng@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> Reviewed-by: Star Zeng <star.zeng@intel.com>
		
			
				
	
	
		
			152 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			152 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/** @file
 | 
						|
 | 
						|
  Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.<BR>
 | 
						|
  SPDX-License-Identifier: BSD-2-Clause-Patent
 | 
						|
 | 
						|
**/
 | 
						|
 | 
						|
#ifndef _SEC_CORE_H_
 | 
						|
#define _SEC_CORE_H_
 | 
						|
 | 
						|
 | 
						|
#include <PiPei.h>
 | 
						|
#include <Ppi/TemporaryRamSupport.h>
 | 
						|
 | 
						|
#include <Library/BaseLib.h>
 | 
						|
#include <Library/IoLib.h>
 | 
						|
#include <Library/DebugLib.h>
 | 
						|
#include <Library/PcdLib.h>
 | 
						|
#include <Library/BaseMemoryLib.h>
 | 
						|
#include <Library/PciCf8Lib.h>
 | 
						|
#include <Library/SerialPortLib.h>
 | 
						|
#include <Library/FspSwitchStackLib.h>
 | 
						|
#include <Library/FspCommonLib.h>
 | 
						|
#include <FspEas.h>
 | 
						|
 | 
						|
typedef VOID (*PEI_CORE_ENTRY) ( \
 | 
						|
  IN CONST  EFI_SEC_PEI_HAND_OFF    *SecCoreData, \
 | 
						|
  IN CONST  EFI_PEI_PPI_DESCRIPTOR  *PpiList \
 | 
						|
);
 | 
						|
 | 
						|
typedef struct _SEC_IDT_TABLE {
 | 
						|
  //
 | 
						|
  // Reserved 8 bytes preceding IDT to store EFI_PEI_SERVICES**, since IDT base
 | 
						|
  // address should be 8-byte alignment.
 | 
						|
  // Note: For IA32, only the 4 bytes immediately preceding IDT is used to store
 | 
						|
  // EFI_PEI_SERVICES**
 | 
						|
  //
 | 
						|
  UINT64            PeiService;
 | 
						|
  UINT64            IdtTable[FixedPcdGet8 (PcdFspMaxInterruptSupported)];
 | 
						|
} SEC_IDT_TABLE;
 | 
						|
 | 
						|
/**
 | 
						|
  Switch the stack in the temporary memory to the one in the permanent memory.
 | 
						|
 | 
						|
  This function must be invoked after the memory migration immediately. The relative
 | 
						|
  position of the stack in the temporary and permanent memory is same.
 | 
						|
 | 
						|
  @param[in] TemporaryMemoryBase  Base address of the temporary memory.
 | 
						|
  @param[in] PermenentMemoryBase  Base address of the permanent memory.
 | 
						|
**/
 | 
						|
VOID
 | 
						|
EFIAPI
 | 
						|
SecSwitchStack (
 | 
						|
  IN UINT32   TemporaryMemoryBase,
 | 
						|
  IN UINT32   PermenentMemoryBase
 | 
						|
  );
 | 
						|
 | 
						|
/**
 | 
						|
  This service of the TEMPORARY_RAM_SUPPORT_PPI that migrates temporary RAM into
 | 
						|
  permanent memory.
 | 
						|
 | 
						|
  @param[in] PeiServices            Pointer to the PEI Services Table.
 | 
						|
  @param[in] TemporaryMemoryBase    Source Address in temporary memory from which the SEC or PEIM will copy the
 | 
						|
                                Temporary RAM contents.
 | 
						|
  @param[in] PermanentMemoryBase    Destination Address in permanent memory into which the SEC or PEIM will copy the
 | 
						|
                                Temporary RAM contents.
 | 
						|
  @param[in] CopySize               Amount of memory to migrate from temporary to permanent memory.
 | 
						|
 | 
						|
  @retval EFI_SUCCESS           The data was successfully returned.
 | 
						|
  @retval EFI_INVALID_PARAMETER PermanentMemoryBase + CopySize > TemporaryMemoryBase when
 | 
						|
                                TemporaryMemoryBase > PermanentMemoryBase.
 | 
						|
 | 
						|
**/
 | 
						|
EFI_STATUS
 | 
						|
EFIAPI
 | 
						|
SecTemporaryRamSupport (
 | 
						|
  IN CONST EFI_PEI_SERVICES   **PeiServices,
 | 
						|
  IN EFI_PHYSICAL_ADDRESS     TemporaryMemoryBase,
 | 
						|
  IN EFI_PHYSICAL_ADDRESS     PermanentMemoryBase,
 | 
						|
  IN UINTN                    CopySize
 | 
						|
  );
 | 
						|
 | 
						|
/**
 | 
						|
  Initializes floating point units for requirement of UEFI specification.
 | 
						|
 | 
						|
  This function initializes floating-point control word to 0x027F (all exceptions
 | 
						|
  masked,double-precision, round-to-nearest) and multimedia-extensions control word
 | 
						|
  (if supported) to 0x1F80 (all exceptions masked, round-to-nearest, flush to zero
 | 
						|
  for masked underflow).
 | 
						|
 | 
						|
**/
 | 
						|
VOID
 | 
						|
EFIAPI
 | 
						|
InitializeFloatingPointUnits (
 | 
						|
  VOID
 | 
						|
  );
 | 
						|
 | 
						|
/**
 | 
						|
 | 
						|
  Entry point to the C language phase of SEC. After the SEC assembly
 | 
						|
  code has initialized some temporary memory and set up the stack,
 | 
						|
  the control is transferred to this function.
 | 
						|
 | 
						|
 | 
						|
  @param[in] SizeOfRam          Size of the temporary memory available for use.
 | 
						|
  @param[in] TempRamBase        Base address of temporary ram
 | 
						|
  @param[in] BootFirmwareVolume Base address of the Boot Firmware Volume.
 | 
						|
  @param[in] PeiCore            PeiCore entry point.
 | 
						|
  @param[in] BootLoaderStack    BootLoader stack.
 | 
						|
  @param[in] ApiIdx             the index of API.
 | 
						|
 | 
						|
  @return This function never returns.
 | 
						|
 | 
						|
**/
 | 
						|
VOID
 | 
						|
EFIAPI
 | 
						|
SecStartup (
 | 
						|
  IN UINT32                   SizeOfRam,
 | 
						|
  IN UINT32                   TempRamBase,
 | 
						|
  IN VOID                    *BootFirmwareVolume,
 | 
						|
  IN PEI_CORE_ENTRY           PeiCore,
 | 
						|
  IN UINT32                   BootLoaderStack,
 | 
						|
  IN UINT32                   ApiIdx
 | 
						|
  );
 | 
						|
 | 
						|
/**
 | 
						|
  Autogenerated function that calls the library constructors for all of the module's
 | 
						|
  dependent libraries.  This function must be called by the SEC Core once a stack has
 | 
						|
  been established.
 | 
						|
 | 
						|
**/
 | 
						|
VOID
 | 
						|
EFIAPI
 | 
						|
ProcessLibraryConstructorList (
 | 
						|
  VOID
 | 
						|
  );
 | 
						|
 | 
						|
/**
 | 
						|
 | 
						|
  Return value of esp.
 | 
						|
 | 
						|
  @return  value of esp.
 | 
						|
 | 
						|
**/
 | 
						|
UINT32
 | 
						|
EFIAPI
 | 
						|
AsmReadEsp (
 | 
						|
  VOID
 | 
						|
  );
 | 
						|
 | 
						|
#endif
 |