Some users are reporting that a debounce time of 5ms is not enough to
prevent keys from registering twice. Split the difference between the
old and the new debounce times and set it to 10ms.
Ref: https://github.com/system76/firmware-open/issues/471
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Implement a FnLock toggle that behaves as follows:
- Disabled: F1-F12 are normal
- Enabled: F1-F12 are the alternate function
Signed-off-by: Tim Crawford <tcrawford@system76.com>
If eSPI is used, use Virtual Wires to determine if PECI is available.
Fixes incorrectly reporting PECI as available on systems using S0ix, as
the CPU would be in C10 but `PLTRST#` would not be asserted.
Requires enabling `HOST_C10` reporting in FSP-S.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Replace symlinks with directories with `board.mk`, using relative paths
to include the files rather than duplicate them.
This allows making board-specific changes without affecting other
boards, such as when firmware security had to be enabled on galp6 when
it was enabled on galp7 (2d5cbadf71).
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Remove checking against the real keys declared in the keymap. It appears
to have no effect on behavior.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Use the default mode for reading the keyboard scan matrix when being
used as a keyboard. There should be no perceived change in behavior, but
should make the code easier to understand.
Note: `KSO[17:16]` are configured by `GPCRC` on boards that use them.
They are now set to alternate function to use in KBS mode rather than
GPIO mode, with the pull-up enabled to prevent them from floating when
configured as open-drain.
As part of this change, we now only read the hardware matrix state once
upfront, instead of on every iteration through the loop applying the
logic.
Tested by verifying that typing still works on darp9.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
A single timer is used for debouncing all keys, so there is no reason to
perform any operations if the matrix is being debounced. Just return
early and remove some of the convoluted logic.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Enable PWRSW WDT 2 and use the default timeout of 10 seconds.
Allows forcing an EC reset in case it gets into an invalid state.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Set D6 and D7 to ALT to use as tachometers inputs from the fans.
Matches config for all other boards.
Ref: IT5570E V0.3.2 datasheet; 7.5.4 Alternate Function Selection
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Allows increased typing speed while avoiding repeating keys due to
contact bounce and keys being rejected by ghost key detection.
This is the default value for QMK.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
PRS3 is 0.005 Ohms.
However, I am unsure about this change because PRS1 and PRS2 are also
both 0.005 Ohms, but are in *parallel*.
Ref: bonw15 schematics, Charger (Sheet 70)
Signed-off-by: Tim Crawford <tcrawford@system76.com>
PRS1 is 5, but it is in series with PRS3, which is also 5. PRS1 by
itself is only connected to ACP/ACN.
Ref: oryp11 schematics, AC In Charger (Sheet 59)
Ref: serw13 schematics, AC_In, Charger (Sheet 70)
Signed-off-by: Tim Crawford <tcrawford@system76.com>
The PECI-over-eSPI implementation, like the legacy implementation, must
acknowledge when the transaction is done by clearing the bit in the
register.
Fixes a hang during shutdown on oryp11 after unplugging a TBT display.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Despite the darp9 supporting an RGB backlit keyboard, the keyboard
option was removed and it ships with a white-only LED backlit keyboard
instead. The keypad `/` still has the cycle symbol printed on it, so
replace the color cycling function with the keyboard brightness
function used by other white-only LED keyboards (the 14" TKL ones).
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Replace the get+set logic with a step function to change the backlight
level for `K_KBD_BKL`.
Keyboards using a DAC have a different set of levels due to the
brightness difference between the keyboards.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Make `white_dac` functions work based on the DAC power level like the
other I2C and PWM mechanisms, instead of preset values from an array.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Existing FDAT values remain unchanged in their functionality.
New functionality is added to fill unused FDAT values.
FDAT values correspond to the following functionality:
- 0: Set brightness
- 1: Get brightness
- 2: Get backlight type (new)
- 3: Set color
- 4: Get color (new)
- 5: <unused>
- 6: Set brightness (duplicate)
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Use RGBKB-DET# to determine the type of keyboard connected.
If a white keyboard is attached, always set the color to white, and
always return white for the color.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Limit PL4 based on AC state for all units, not just those with dGPUs.
This will allow setting standard values in coreboot.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
