jenkins: Rebuild the coreboot toolchain

Latest build failed with:

    /bin/sh: 1: /home/jenkins/workspace/firmware-open-pipeline/coreboot/util/crossgcc/xgcc/bin/x86_64-elf-gcc: not found

So try rebuilding the toolchain.

Signed-off-by: Tim Crawford <tcrawford@system76.com>

CHANGELOG.md

@@ -6,7 +6,22 @@ date followed by an underscore and a short git revision. To see if specific
 features apply to your model and firmware version, see the
 [feature matrix](./FEATURES.md).
 
-## unreleased
+## 2024-02-20
+
+- lemp12: Fixed PCIe 4.0 drives in PCIe 3.0 slot failing to reinitialize on
+  resume
+
+## 2023-09-08
+
+- adl: Updated CSME to 16.1.25.2124
+- adl,rpl: Fixed SMMSTORE init sometimes failing
+- Increased key debounce from 5ms to 10ms
+
+## 2023-08-23
+
+- rpl: Fixed RPL-S GPIO driver on Windows
+
+## 2023-08-18
 
 - cml-u: Fixed boot failing at FSP-S
 - Added KBC reset on CPU reset to prevent keyboard from being locked
@@ -14,6 +29,11 @@ features apply to your model and firmware version, see the
 - Fixed detecting if PECI is available on eSPI systems using S0ix
 - Added support for a FnLock key
 - tgl: Fixed Bluetooth performance by enabling audio offload
+- gaze16: Fixed CPU not going lower than C2 due to card reader LTR
+- adl: Fixed CPU not going lower than C2 due to card reader LTR
+- rpl: Fixed CPU not going lower than C2 due to card reader LTR
+- Changed battery charge start threshold to 90%
+- Changed charger to disable when battery is full
 
 ## 2023-07-19
 

Jenkinsfile

@@ -9,14 +9,7 @@
 
 def all_models = 'addw2 addw3 bonw14 bonw15 darp5 darp6 darp7 darp8 darp9 galp3-c galp4 galp5 galp6 galp7 gaze15 gaze16-3050 gaze16-3060 gaze16-3060-b gaze16-3050 gaze16-3060-b gaze17-3050 gaze17-3060-b gaze18 lemp9 lemp10 lemp11 lemp12 oryp5 oryp6 oryp7 oryp8 oryp9 oryp10 oryp11 serw13'
 
-def getCommitSha() {
-  sh "git rev-parse HEAD > .git/current-commit"
-  return readFile(".git/current-commit").trim()
-}
-
 void setBuildStatus(String state, String message) {
-    commit = getCommitSha()
-
     // FIXME: https://www.jenkins.io/doc/book/pipeline/jenkinsfile/#string-interpolation
     sh """
     curl \
@@ -24,7 +17,7 @@ void setBuildStatus(String state, String message) {
       -H \'Accept: application/vnd.github+json\' \
       -H \'Authorization: Bearer ${GITHUB_TOKEN}\' \
       -H \'X-GitHub-Api-Version: 2022-11-28\' \
-      https://api.github.com/repos/system76/firmware-open/statuses/${commit} \
+      https://api.github.com/repos/system76/firmware-open/statuses/${GIT_COMMIT} \
       -d \'{\"state\": \"${state}\", \"target_url\": \"${BUILD_URL}\", \"description\": \"${message}\"}\'
     """
 }
@@ -48,7 +41,7 @@ pipeline {
 
     parameters {
         string(name: 'MODELS', defaultValue: "$all_models", description: 'Space separated list of models to build', trim: true)
-        string(name: 'GIT_BRANCH', defaultValue: 'master', description: 'Git branch or revision to build', trim: true)
+        string(name: 'SOURCE_BRANCH', defaultValue: 'master', description: 'Git branch or revision to build', trim: true)
     }
 
     triggers {
@@ -58,26 +51,29 @@ pipeline {
     stages {
         stage('Prepare') {
             steps {
-                checkout([
-                    $class: 'GitSCM',
-                    branches: [[name: "${GIT_BRANCH}"]],
+                setBuildStatus("pending", "Pending")
+                slackSend(color: "good", message: "${env.JOB_NAME} - #${env.BUILD_ID} started (<${env.BUILD_URL}|Open>)")
+
+                sh """#!/bin/bash
+                    # Update submodule URLs because of coreboot
+                    git submodule sync --recursive
+                """
+
+                // https://www.jenkins.io/doc/pipeline/steps/params/scmgit/
+                checkout scmGit(
+                    branches: [[name: '${SOURCE_BRANCH}']],
                     extensions: [
-                        [
-                            $class: 'SubmoduleOption',
-                            disableSubmodules: false,
+                        lfs(),
+                        pruneStaleBranch(),
+                        pruneTags(true),
+                        submodule(
                             parentCredentials: true,
                             recursiveSubmodules: true,
-                            reference: '',
-                            trackingSubmodules: false
-                        ],
-                        [ $class: 'GitLFSPull' ],
-                        [ $class: 'PruneStaleBranch' ],
+                            reference: ''
+                        ),
                     ],
-                    userRemoteConfigs: [[url: 'https://github.com/system76/firmware-open']]
-                ])
-
-                setBuildStatus("pending", "Pending")
-                slackSend(color: "good", message: "${JOB_NAME} - #${BUILD_ID} started (<${BUILD_URL}|Open>)")
+                    userRemoteConfigs: [[url: 'https://github.com/system76/firmware-open.git']]
+                )
 
                 sh """#!/bin/bash
                     # Install dependencies
@@ -93,6 +89,9 @@ pipeline {
                     git clean -dffx
                     git submodule foreach --recursive git clean -dff
 
+                    # FIXME: Rebuild the coreboot toolchain
+                    make -C coreboot CPUS="\$(nproc)" crossgcc-i386 crossgcc-x64
+
                     # EDK2 builds fail if file paths in INFs change from what's in the build cache
                     pushd edk2; git clean -dffx; popd
                 """
@@ -124,15 +123,15 @@ pipeline {
         }
         success {
             setBuildStatus("success", "Successful")
-            slackSend(color: "good", message: "${JOB_NAME} - #${BUILD_ID} successful (<${BUILD_URL}|Open>)")
+            slackSend(color: "good", message: "${env.JOB_NAME} - #${env.BUILD_ID} successful after ${currentBuild.durationString} (<${env.BUILD_URL}|Open>)")
         }
         failure {
             setBuildStatus("failure", "Failed")
-            slackSend(color: "danger", message: "${JOB_NAME} - #${BUILD_ID} failed (<${BUILD_URL}|Open>)")
+            slackSend(color: "danger", message: "${env.JOB_NAME} - #${env.BUILD_ID} failed after ${currentBuild.durationString} (<${env.BUILD_URL}|Open>)")
         }
         aborted {
             setBuildStatus("failure", "Failed")
-            slackSend(color: "warning", message: "${JOB_NAME} - #${BUILD_ID} aborted (<${BUILD_URL}|Open>)")
+            slackSend(color: "warning", message: "${env.JOB_NAME} - #${env.BUILD_ID} aborted after ${currentBuild.durationString} (<${env.BUILD_URL}|Open>)")
         }
     }
 }

docs/intel-me.md

@@ -27,6 +27,34 @@ A restart is required for the change to take effect. On the boot after changing
 the value, the system will perform a global reset (power off again) to complete
 the change and ensure the IME is operating in a valid state.
 
+### Checking the state
+
+coreboot will log some IME data to cbmem during startup. This can be used to
+check if it is in the correct state.
+
+```
+make -C coreboot/util/cbmem
+sudo ./coreboot/util/cbmem/cbmem -c
+```
+
+When disabled it will report:
+
+```
+ME: Current Working State       : 4
+ME: Current Operation State     : 1
+ME: Current Operation Mode      : 3
+ME: Error Code                  : 2
+```
+
+When enabled it will report:
+
+```
+ME: Current Working State       : 5
+ME: Current Operation State     : 1
+ME: Current Operation Mode      : 0
+ME: Error Code                  : 0
+```
+
 ## Tiger Lake-U
 
 Models using TGL-U processors default to having the IME enabled. TGL-U removes

models/darp8/README.md

@@ -9,4 +9,4 @@
   - HAP: false
 - [ME](./me.rom)
   - Size: 4824 KB
-  - Version: 16.0.15.1829
+  - Version: 16.1.25.2124

models/galp6/README.md

@@ -9,4 +9,4 @@
   - HAP: false
 - [ME](./me.rom)
   - Size: 4824 KB
-  - Version: 16.0.15.1829
+  - Version: 16.1.25.2124

models/gaze17-3050/README.md

@@ -9,4 +9,4 @@
   - HAP: false
 - [ME](./me.rom)
   - Size: 4824 KB
-  - Version: 16.0.15.1829
+  - Version: 16.1.25.2124

models/gaze17-3060-b/README.md

@@ -9,4 +9,4 @@
   - HAP: false
 - [ME](./me.rom)
   - Size: 4824 KB
-  - Version: 16.0.15.1829
+  - Version: 16.1.25.2124

models/lemp11/README.md

@@ -9,4 +9,4 @@
   - HAP: false
 - [ME](./me.rom)
   - Size: 4824 KB
-  - Version: 16.0.15.1829
+  - Version: 16.1.25.2124

models/oryp10/README.md

@@ -9,4 +9,4 @@
   - HAP: false
 - [ME](./me.rom)
   - Size: 4824 KB
-  - Version: 16.0.15.1829
+  - Version: 16.1.25.2124

models/oryp9/README.md

@@ -9,4 +9,4 @@
   - HAP: false
 - [ME](./me.rom)
   - Size: 4824 KB
-  - Version: 16.0.15.1829
+  - Version: 16.1.25.2124