soc/intel/*: Correct ACPI device name for eMMC
The ACPI name of any device needs to match the name used for generating the S0i3 LPI constraint list, which comes from soc_acpi_name() for each SoC. The names used for the eMMC controller do not match, which will lead to broken ACPI tables since the LPI constriant will reference an ACPI device which does not exist. Some OSes tolerate this better than others, but it should still be corrected. TEST=build/boot google/{hatch,volteer, brya}, dump ACPI and verify no invalid device names referenced. Change-Id: Icbc22b6b2a84bbe73f1b09083f27081612db5eba Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78825 Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Subrata Banik <subratabanik@google.com> Reviewed-by: Eric Lai <ericllai@google.com>
This commit is contained in:
committed by
Matt DeVillier
parent
739f83eb0b
commit
19799b4cd9
@@ -18,7 +18,7 @@ Scope (\_SB.PCI0) {
|
||||
}
|
||||
|
||||
/* EMMC */
|
||||
Device(PEMC) {
|
||||
Device(EMMC) {
|
||||
Name(_ADR, 0x001A0000)
|
||||
Name (_DDN, "eMMC Controller")
|
||||
Name(TEMP, 0)
|
||||
|
@@ -15,7 +15,7 @@ Scope (\_SB.PCI0) {
|
||||
}
|
||||
|
||||
/* EMMC */
|
||||
Device(PEMC) {
|
||||
Device(EMMC) {
|
||||
Name(_ADR, 0x001A0000)
|
||||
Name (_DDN, "eMMC Controller")
|
||||
Name (TEMP, 0)
|
||||
|
@@ -15,7 +15,7 @@ Scope (\_SB.PCI0) {
|
||||
}
|
||||
|
||||
/* EMMC */
|
||||
Device(PEMC) {
|
||||
Device(EMMC) {
|
||||
Name(_ADR, 0x001A0000)
|
||||
Name (_DDN, "eMMC Controller")
|
||||
Name (TEMP, 0)
|
||||
|
@@ -15,7 +15,7 @@ Scope (\_SB.PCI0) {
|
||||
}
|
||||
|
||||
/* EMMC */
|
||||
Device(PEMC) {
|
||||
Device(EMMC) {
|
||||
Name(_ADR, 0x001A0000)
|
||||
Name (_DDN, "eMMC Controller")
|
||||
Name (TEMP, 0)
|
||||
|
Reference in New Issue
Block a user