soc/amd/common,genoa_poc/domain: rework check for 1st domain
Previously the code checked if the first downstream bus of the domain was bus 0 in segment group 0 to only run certain code for the first domain. Instead check if the domain number is 0 which should make the code a bit easier to understand. TEST=add_opensil_memmap still gets called exactly once on Onyx Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Id8cc0078843e5e0361a53ba897cde508cee16aad Reviewed-on: https://review.coreboot.org/c/coreboot/+/79996 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
@@ -254,7 +254,7 @@ void amd_pci_domain_fill_ssdt(const struct device *domain)
|
||||
acpigen_resource_producer_bus_number(domain->downstream->secondary,
|
||||
domain->downstream->max_subordinate);
|
||||
|
||||
if (domain->downstream->secondary == 0 && domain->downstream->segment_group == 0) {
|
||||
if (domain->path.domain.domain == 0) {
|
||||
/* ACPI 6.4.2.5 I/O Port Descriptor */
|
||||
acpigen_write_io16(PCI_IO_CONFIG_INDEX, PCI_IO_CONFIG_LAST_PORT, 1,
|
||||
PCI_IO_CONFIG_PORT_COUNT, 1);
|
||||
|
@@ -18,7 +18,7 @@ static void genoa_domain_read_resources(struct device *domain)
|
||||
amd_pci_domain_read_resources(domain);
|
||||
|
||||
// We only want to add the DRAM memory map once
|
||||
if (domain->downstream->secondary == 0 && domain->downstream->segment_group == 0) {
|
||||
if (domain->path.domain.domain == 0) {
|
||||
/* 0x1000 is a large enough first index to be sure to not overlap with the
|
||||
resources added by amd_pci_domain_read_resources */
|
||||
add_opensil_memmap(domain, 0x1000);
|
||||
|
Reference in New Issue
Block a user