sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/trulo: Keep ISH default enable

Browse Source 
This patch drops fw_config probing for ISH because ISH IP should
remains on by default for all Trulo variants.

Additionally, removed the redundant ISH entries from variant
override devicetree.

BUG=b:354607924
TEST=Able to verify ISH PCI Device is available while booting eMMC sku.

```
lspci
00:00.0 Host bridge: Intel Corporation Device 461c
...
00:12.0 Serial controller: Intel Corporation Device 54fc
...
00:1a.0 SD Host controller: Intel Corporation Device 54c4
```

Also, able to enter S0ix with this patch.

```
> suspend_stress_test -c 1 --ignore_s0ix_substates

At AP console:

s0ix errors: 0
s0ix substate errors: 0
s0ix pc10 errors: 0

At EC console:
power state 5 = S0ix, in 0x38d87
```
Change-Id: Ic1e415ec848ac91a9bbf21b26597f4e6b5f7a1f5
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83695
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
Reviewed-by: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2024-07-30 18:33:11 +05:30
parent 42e4dd5aef
commit 8200a9ac38
3 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb
View File

@ -45,6 +45,12 @@ chip soc/intel/alderlake
device ref igpu on end
device ref dtt on end
device ref tcss_xhci on end
device ref ish on
chip drivers/intel/ish
register "add_acpi_dma_property" = "true"
device generic 0 on end
end
end
device ref xhci on end
device ref shared_sram on end
device ref heci1 on end

8
src/mainboard/google/brya/variants/orisa/overridetree.cb
View File

@ -512,14 +512,6 @@ chip soc/intel/alderlake
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_EMMC
end
device ref ish on
chip drivers/intel/ish
register "add_acpi_dma_property" = "true"
device generic 0 on end
end
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_UFS
end
device ref ufs on
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_UFS

8
src/mainboard/google/brya/variants/trulo/overridetree.cb
View File

@ -518,14 +518,6 @@ chip soc/intel/alderlake
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_EMMC
end
device ref ish on
chip drivers/intel/ish
register "add_acpi_dma_property" = "true"
device generic 0 on end
end
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_UFS
end
device ref ufs on
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_UFS