soc/intel/common: Consistently use smbus 7-bit address log format
The "No memory dimm at address" line in get_spd_sn and get_spd fucntion have different format of SPD address. get_spd_sn shows a 8-bit address format but get_spd shows a 7-bit address format when there is no DIMM connected. It can be confusing when debugging. Change-Id: I46a006f4024b12d27ae0a933b7c40515034d5d64 Signed-off-by: Kane Chen <kane.chen@intel.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/64290 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jamie Chen <jamie.chen@intel.com> Reviewed-by: Subrata Banik <subratabanik@google.com> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
@@ -105,7 +105,7 @@ enum cb_err get_spd_sn(u8 addr, u32 *sn)
|
||||
/* If dimm is not present, set sn to 0xff. */
|
||||
smbus_ret = smbus_read_byte(addr, SPD_DRAM_TYPE);
|
||||
if (smbus_ret < 0) {
|
||||
printk(BIOS_INFO, "No memory dimm at address %02X\n", addr);
|
||||
printk(BIOS_INFO, "No memory dimm at address %02X\n", addr << 1);
|
||||
*sn = 0xffffffff;
|
||||
return CB_SUCCESS;
|
||||
}
|
||||
|
Reference in New Issue
Block a user