sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc/amd/opensil/genoa_poc/mpio: simplify per_device_config arguments

Browse Source 
Since we're already passing a pointer to the corresponding device to
per_device_config, we don't need to pass the chip_info as separate
parameter. Before moving the PCIe port function device below the MPIO
chip, the chip_info struct was from a different device, so that change
allows this simplification.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I0466f7ad2f5c9874d45712fa9f89b978bd2a09bc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81341
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
This commit is contained in:
Felix Held 2024-03-18 21:19:45 +01:00
parent 4b187551d2
commit e261aa0aa7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
View File

@ -125,12 +125,12 @@ static void setup_bmc_lanes(uint8_t lane, uint8_t socket)
mpio_data->EarlyBmcLinkDie = 0;
}
static void per_device_config(MPIOCLASS_INPUT_BLK *mpio_data, struct device *dev,
struct vendorcode_amd_opensil_genoa_poc_mpio_config *const config)
static void per_device_config(MPIOCLASS_INPUT_BLK *mpio_data, struct device *dev)
{
static uint32_t slot_num;
const uint32_t domain = dev->upstream->dev->path.domain.domain;
const uint32_t devfn = dev->path.pci.devfn;
const struct vendorcode_amd_opensil_genoa_poc_mpio_config *const config = dev->chip_info;
printk(BIOS_DEBUG, "Setting MPIO port for domain 0x%x, PCI %d:%d\n",
domain, PCI_SLOT(devfn), PCI_FUNC(devfn));
@ -198,5 +198,5 @@ void configure_mpio(void)
for (struct device *dev = &dev_root; dev; dev = dev->next)
if (dev->chip_ops == &vendorcode_amd_opensil_genoa_poc_mpio_ops &&
dev->chip_info != dev->upstream->dev->chip_info)
per_device_config(mpio_data, dev, dev->chip_info);
per_device_config(mpio_data, dev);
}