As somewhat of a hack, allow flashing only the EC by deleting the
`firmware.rom` file before running `flash.sh`.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
`flash.sh` was changed from internally flashing to using the UEFI
application (firmware-update). The option `--without-ec` was removed as
part of this.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Caching ramtop does not update the checksum, causing CMOS options to not
work. Fixes CSME not being disabled on first boot.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
- coreboot: Disable AER on TBT port to avoid UnsupReq error
- ec: Select the correct smart charger to fix charging issue
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Commit 7d6a15e63c ("Convert toolchain file to TOML syntax") switched
from the bare toolchain file to the TOML-based one for better management
of the toolchain and components used.
Commit cf7fc2c540 ("scripts: Update rustup or inform user of env
vars") added an explicit `rustup self update` because there were still
cases, a year later, of people not having a rustup new enough to support
the TOML-based toolchain file.
Now 2 years after that, it should be safe to drop the explicit self
update. The TOML format has widespread adoption and rustup now self
updates by default. This should allow distro-provided rustup, which
disables the self update feature, to work if it is already installed in
place of the one downloaded from https://rustup.rs.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
- Do cold reboot on success instead of shutting down
- Reboot on success after flashing all components
- Do not boot to firmware setup after MeSet
- Flash full EC ROM size instead of hard-coding to 128K
- Add addw4, lemp13, oryp12
Signed-off-by: Tim Crawford <tcrawford@system76.com>
CSME should be enabled when S0ix is used for power savings during
suspend. TGL-U is just one case where we default as our TGL-U models
do not support S3. Other models may use S0ix as well, such as darp8 and
darp9 due to new batches just not working with S3 anymore [1].
[1]: https://github.com/system76/firmware-open/issues/507
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Cherry-pick the following upstream commits:
- coreboot/coreboot@fb401e74da: soc/intel/alderlake: Sync UPD Usb4CmMode with Kconfig
- coreboot/coreboot@961ed9fe27: soc/intel/adl: Set slp-s0 counter frequency
- coreboot/coreboot@377845a9d4: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
- coreboot/coreboot@354a54ac84: soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL
- coreboot/coreboot@adf042f6c6: lib/rtc: Fix off-by-one error in February day count in leap year
This also brings in the WIP addw4, but that will documented in the PR
that adds full support for the board.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Commit 77581d11fc ("models: Remove generated C files") removed the HDA
and GPIO files, but bonw14 had an odd named file that was not removed
with the `find` command.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Since 4.19-based releases took so long, we are already at the next
coreboot release. Update to this release for the slew of MTL fixes.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
These files are generated while running proprietary firmware, but once
they are added to coreboot they are no longer needed. They also quickly
become stale as the files are always changed in coreboot.
find models/ -name gpio.h -exec rm {} \;
find models/ -name hda_verb.c -exec rm {} \;
Signed-off-by: Tim Crawford <tcrawford@system76.com>
I always add HDA reset to the coreboot file when upstreaming, so just
have the script do it.
- Proprietary firmware does it
- It fixed audio init on oryp5
Signed-off-by: Tim Crawford <tcrawford@system76.com>
The whole coreboot generated `.config` has not been used since
ff0a27ad9c ("Use defconfig to generate .config"). The required
`coreboot.config` is much simpler now and can usually just be copied
from another model.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
